Handle nil pointer queue url in manage job cron (#1389)

vishalbollu · web-flow · commit 788c490b1338 · 2020-09-28T11:19:12.000-04:00
diff --git a/pkg/operator/resources/batchapi/manage_resources_cron.go b/pkg/operator/resources/batchapi/manage_resources_cron.go
@@ -116,7 +116,6 @@ func ManageJobResources() error {
 			errors.PrintError(err)
 			continue
 		}
-
 		if newStatusCode != jobState.Status {
 			err = errors.FirstError(
 				writeToJobLogStream(jobKey, msg),
@@ -128,6 +127,10 @@ func ManageJobResources() error {
 				continue
 			}
 		}
+		if queueURL == nil {
+			// job has been submitted within the grace period, it may take a while for a newly created queue to be listed in SQS api response
+			continue
+		}
 
 		err = checkIfJobCompleted(jobKey, *queueURL, k8sJob)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,6 @@ func ManageJobResources() error {`
`116`	`116`	`errors.PrintError(err)`
`117`	`117`	`continue`
`118`	`118`	`}`
`119`		`-`
`120`	`119`	`if newStatusCode != jobState.Status {`
`121`	`120`	`err = errors.FirstError(`
`122`	`121`	`writeToJobLogStream(jobKey, msg),`
`@@ -128,6 +127,10 @@ func ManageJobResources() error {`
`128`	`127`	`continue`
`129`	`128`	`}`
`130`	`129`	`}`
	`130`	`+ if queueURL == nil {`
	`131`	`+ // job has been submitted within the grace period, it may take a while for a newly created queue to be listed in SQS api response`
	`132`	`+ continue`
	`133`	`+ }`
`131`	`134`
`132`	`135`	`err = checkIfJobCompleted(jobKey, *queueURL, k8sJob)`
`133`	`136`	`if err != nil {`