Skip to content

Commit 7138b5c

Browse files
committed
Add space before progress indicator check marks
1 parent 36fb4a9 commit 7138b5c

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

cli/local/model_cache.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func CacheModel(modelPath string, awsClient *aws.Client) (*spec.LocalModelCache,
106106

107107
func downloadModel(modelPath string, modelDir string, awsClient *aws.Client) error {
108108
fmt.Printf("○ downloading model %s ", modelPath)
109-
defer fmt.Print("✓\n")
109+
defer fmt.Print(" \n")
110110
dotCron := cron.Run(print.Dot, nil, 2*time.Second)
111111
defer dotCron.Cancel()
112112

manager/debug.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ echo -n "."
4848
(cd /.cortex && tar -czf cortex-debug.tgz cortex-debug)
4949
rm -rf /.cortex/cortex-debug
5050

51-
echo ""
51+
echo " "

manager/install.sh

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ function ensure_eks() {
113113
if [[ -n $asg_spot_name ]]; then
114114
aws autoscaling update-auto-scaling-group --region $CORTEX_REGION --auto-scaling-group-name $asg_spot_name --min-size=$CORTEX_MIN_INSTANCES
115115
fi
116-
echo ""
116+
echo " "
117117
fi
118118

119119
if [ "$asg_max_size" != "$CORTEX_MAX_INSTANCES" ]; then
@@ -124,7 +124,7 @@ function ensure_eks() {
124124
if [[ -n $asg_spot_name ]]; then
125125
aws autoscaling update-auto-scaling-group --region $CORTEX_REGION --auto-scaling-group-name $asg_spot_name --max-size=$CORTEX_MAX_INSTANCES
126126
fi
127-
echo ""
127+
echo " "
128128
fi
129129
}
130130

@@ -147,38 +147,38 @@ function main() {
147147
echo -n "○ updating cluster configuration "
148148
setup_configmap
149149
setup_secrets
150-
echo ""
150+
echo " "
151151

152152
echo -n "○ configuring networking "
153153
setup_istio
154154
envsubst < manifests/apis.yaml | kubectl apply -f - >/dev/null
155-
echo ""
155+
echo " "
156156

157157
echo -n "○ configuring autoscaling "
158158
python render_template.py $CORTEX_CLUSTER_CONFIG_FILE manifests/cluster-autoscaler.yaml.j2 > $CORTEX_CLUSTER_WORKSPACE/cluster-autoscaler.yaml
159159
kubectl apply -f $CORTEX_CLUSTER_WORKSPACE/cluster-autoscaler.yaml >/dev/null
160-
echo ""
160+
echo " "
161161

162162
echo -n "○ configuring logging "
163163
envsubst < manifests/fluentd.yaml | kubectl apply -f - >/dev/null
164-
echo ""
164+
echo " "
165165

166166
echo -n "○ configuring metrics "
167167
envsubst < manifests/metrics-server.yaml | kubectl apply -f - >/dev/null
168168
envsubst < manifests/statsd.yaml | kubectl apply -f - >/dev/null
169-
echo ""
169+
echo " "
170170

171171
if [[ "$CORTEX_INSTANCE_TYPE" == p* ]] || [[ "$CORTEX_INSTANCE_TYPE" == g* ]]; then
172172
echo -n "○ configuring gpu support "
173173
envsubst < manifests/nvidia.yaml | kubectl apply -f - >/dev/null
174-
echo ""
174+
echo " "
175175
fi
176176

177177
echo -n "○ starting operator "
178178
kubectl -n=default delete --ignore-not-found=true --grace-period=10 deployment operator >/dev/null 2>&1
179179
until [ "$(kubectl -n=default get pods -l workloadID=operator -o json | jq -j '.items | length')" -eq "0" ]; do echo -n "."; sleep 2; done
180180
envsubst < manifests/operator.yaml | kubectl apply -f - >/dev/null
181-
echo ""
181+
echo " "
182182

183183
validate_cortex
184184

@@ -192,12 +192,12 @@ function main() {
192192
sleep 3
193193
done
194194
kubectl -n=default delete --ignore-not-found=true daemonset image-downloader &>/dev/null
195-
echo ""
195+
echo " "
196196
fi
197197

198198
echo -n "○ configuring cli "
199199
python update_cli_config.py "/.cortex/cli.yaml" "$CORTEX_ENV_NAME" "$operator_endpoint" "$CORTEX_AWS_ACCESS_KEY_ID" "$CORTEX_AWS_SECRET_ACCESS_KEY"
200-
echo ""
200+
echo " "
201201

202202
echo -e "\ncortex is ready!"
203203
}
@@ -336,7 +336,7 @@ function validate_cortex() {
336336
break
337337
done
338338

339-
echo ""
339+
echo " "
340340
}
341341

342342
main

pkg/lib/docker/docker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ func PullImage(image string, encodedAuthConfig string, pullVerbosity PullVerbosi
170170
fmt.Println()
171171
case PrintDots:
172172
fmt.Printf("○ downloading docker image %s ", image)
173-
defer fmt.Print("✓\n")
173+
defer fmt.Print(" \n")
174174
dotCron := cron.Run(print.Dot, nil, 2*time.Second)
175175
defer dotCron.Cancel()
176176
// wait until the pull has completed

0 commit comments

Comments
 (0)