Skip to content

Commit 6c4deed

Browse files
authored
Fix scale-to-zero E2E test (#2385)
1 parent 45812e5 commit 6c4deed

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

test/e2e/e2e/tests.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,9 +476,7 @@ def test_autoscaling(
476476
assert api_updated(
477477
client, primary_api_name, timeout=deploy_timeout
478478
), "api didn't scale up to the desired number of replicas in time"
479-
current_replicas = client.get_api(primary_api_name)["status"]["replica_counts"][
480-
"requested"
481-
]
479+
current_replicas = client.get_api(primary_api_name)["status"]["requested"]
482480

483481
# stop the requests from being made
484482
if current_replicas == max_replicas and not request_stopper.is_set():
@@ -908,7 +906,7 @@ def test_realtime_scale_to_zero(
908906

909907
try:
910908
assert apis_ready(
911-
client=client, api_names=[api_name], timeout=timeout
909+
client=client, api_names=[api_name], timeout=timeout, greater_or_equal_to=0
912910
), f"apis {api_name} not ready"
913911

914912
api_info = client.get_api(api_name)

test/e2e/e2e/utils.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,15 @@ def wait_for(fn: Callable[[], bool], timeout=None) -> bool:
3737
time.sleep(1)
3838

3939

40-
def apis_ready(client: cx.Client, api_names: List[str], timeout: Optional[int] = None) -> bool:
40+
def apis_ready(
41+
client: cx.Client,
42+
api_names: List[str],
43+
timeout: Optional[int] = None,
44+
greater_or_equal_to: int = 1,
45+
) -> bool:
4146
def _check_liveness(status):
4247
return (
43-
status["requested"] > 0
48+
status["requested"] >= greater_or_equal_to
4449
and status["requested"] == status["ready"] == status["up_to_date"]
4550
)
4651

0 commit comments

Comments
 (0)