Do not remove cluster configuring if refresh fails (#893)

Author: vishalbollu

cli/cmd/cluster.go

@@ -321,11 +321,9 @@ func refreshCachedClusterConfig(awsCreds AWSCredentials) clusterconfig.Config {
 	fmt.Println("fetching cluster configuration ..." + "\n")
 	out, exitCode, err := runManagerAccessCommand("/root/refresh.sh "+mountedConfigPath, *accessConfig, awsCreds)
 	if err != nil {
-		os.Remove(cachedConfigPath)
 		exit.Error(err)
 	}
 	if exitCode == nil || *exitCode != 0 {
-		os.Remove(cachedConfigPath)
 		exit.Error(ErrorClusterRefresh(out))
 	}
 

manager/refresh.sh

@@ -27,8 +27,10 @@ fi
 eksctl utils write-kubeconfig --cluster=$CORTEX_CLUSTER_NAME --region=$CORTEX_REGION | grep -v "saved kubeconfig as" | grep -v "using region" | grep -v "eksctl version" || true
 
 kubectl get -n=default configmap cluster-config -o yaml >> cluster_configmap.yaml
-python refresh_cluster_config.py cluster_configmap.yaml $cached_cluster_config_file
+python refresh_cluster_config.py cluster_configmap.yaml tmp_cluster_config.yaml
 
 kubectl -n=default create configmap 'cluster-config' \
-    --from-file='cluster.yaml'=$cached_cluster_config_file \
+    --from-file='cluster.yaml'=tmp_cluster_config.yaml \
     -o yaml --dry-run | kubectl apply -f - >/dev/null
+
+cp tmp_cluster_config.yaml $cached_cluster_config_file