Check error before assigning api (#776)

vishalbollu · web-flow · commit 334550bffd24 · 2020-01-21T19:05:20.000-05:00
diff --git a/pkg/operator/endpoints/deploy.go b/pkg/operator/endpoints/deploy.go
@@ -89,10 +89,11 @@ func Deploy(w http.ResponseWriter, r *http.Request) {
 	results := make([]schema.DeployResult, len(apiConfigs))
 	for i, apiConfig := range apiConfigs {
 		api, msg, err := operator.UpdateAPI(&apiConfig, projectID, force)
-		results[i].API = *api
 		results[i].Message = msg
 		if err != nil {
 			results[i].Error = errors.Message(err)
+		} else {
+			results[i].API = *api
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,11 @@ func Deploy(w http.ResponseWriter, r *http.Request) {`
`89`	`89`	`results := make([]schema.DeployResult, len(apiConfigs))`
`90`	`90`	`for i, apiConfig := range apiConfigs {`
`91`	`91`	`api, msg, err := operator.UpdateAPI(&apiConfig, projectID, force)`
`92`		`- results[i].API = *api`
`93`	`92`	`results[i].Message = msg`
`94`	`93`	`if err != nil {`
`95`	`94`	`results[i].Error = errors.Message(err)`
	`95`	`+ } else {`
	`96`	`+ results[i].API = *api`
`96`	`97`	`}`
`97`	`98`	`}`
`98`	`99`