Suppress s3 deletion error (#903)

vishalbollu · web-flow · commit 23eb519499d0 · 2020-03-23T21:09:29.000-04:00
diff --git a/pkg/operator/operator/api.go b/pkg/operator/operator/api.go
@@ -142,7 +142,10 @@ func DeleteAPI(apiName string, keepCache bool) error {
 			if keepCache {
 				return nil
 			}
-			return deleteS3Resources(apiName)
+
+			// best effort deletion
+			deleteS3Resources(apiName)
+			return nil
 		},
 	)
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,10 @@ func DeleteAPI(apiName string, keepCache bool) error {`
`142`	`142`	`if keepCache {`
`143`	`143`	`return nil`
`144`	`144`	`}`
`145`		`- return deleteS3Resources(apiName)`
	`145`	`+`
	`146`	`+ // best effort deletion`
	`147`	`+ deleteS3Resources(apiName)`
	`148`	`+ return nil`
`146`	`149`	`},`
`147`	`150`	`)`
`148`	`151`