fix(CCarousel): Uncaught TypeError: Cannot read properties of null (reading 'getBoundingClientRect')

mrholek · mrholek · commit bfd1eceab660 · 2023-03-29T14:33:15.000+02:00
diff --git a/packages/coreui-vue/src/components/carousel/CCarousel.ts b/packages/coreui-vue/src/components/carousel/CCarousel.ts
@@ -119,7 +119,7 @@ const CCarousel = defineComponent({
     const nextItemWhenVisible = () => {
       // Don't call next when the page isn't visible
       // or the carousel or its parent isn't visible
-      if (!document.hidden && isInViewport(carouselRef.value)) {
+      if (!document.hidden && carouselRef.value && isInViewport(carouselRef.value)) {
         handleControlClick('next')
       }
     }
@@ -142,7 +142,7 @@ const CCarousel = defineComponent({
     }
 
     const handleScroll = () => {
-      if (!document.hidden && isInViewport(carouselRef.value)) {
+      if (!document.hidden && carouselRef.value && isInViewport(carouselRef.value)) {
         visible.value = true
       } else {
         visible.value = false

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ const CCarousel = defineComponent({`
`119`	`119`	`const nextItemWhenVisible = () => {`
`120`	`120`	`// Don't call next when the page isn't visible`
`121`	`121`	`// or the carousel or its parent isn't visible`
`122`		`- if (!document.hidden && isInViewport(carouselRef.value)) {`
	`122`	`+ if (!document.hidden && carouselRef.value && isInViewport(carouselRef.value)) {`
`123`	`123`	`handleControlClick('next')`
`124`	`124`	`}`
`125`	`125`	`}`
`@@ -142,7 +142,7 @@ const CCarousel = defineComponent({`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`const handleScroll = () => {`
`145`		`- if (!document.hidden && isInViewport(carouselRef.value)) {`
	`145`	`+ if (!document.hidden && carouselRef.value && isInViewport(carouselRef.value)) {`
`146`	`146`	`visible.value = true`
`147`	`147`	`} else {`
`148`	`148`	`visible.value = false`