refactor: fix eslint warnings

mrholek · mrholek · commit 72f1a616b8de · 2023-06-11T18:12:44.000+02:00
diff --git a/packages/coreui-vue/src/components/dropdown/CDropdown.ts b/packages/coreui-vue/src/components/dropdown/CDropdown.ts
@@ -19,22 +19,22 @@ const CDropdown = defineComponent({
         if (value === 'start' || value === 'end') {
           return true
         } else {
-          if (typeof value.xs !== 'undefined' && (value.xs === 'start' || value.xs === 'end')) {
+          if (value.xs !== undefined && (value.xs === 'start' || value.xs === 'end')) {
             return true
           }
-          if (typeof value.sm !== 'undefined' && (value.sm === 'start' || value.sm === 'end')) {
+          if (value.sm !== undefined && (value.sm === 'start' || value.sm === 'end')) {
             return true
           }
-          if (typeof value.md !== 'undefined' && (value.md === 'start' || value.md === 'end')) {
+          if (value.md !== undefined && (value.md === 'start' || value.md === 'end')) {
             return true
           }
-          if (typeof value.lg !== 'undefined' && (value.lg === 'start' || value.lg === 'end')) {
+          if (value.lg !== undefined && (value.lg === 'start' || value.lg === 'end')) {
             return true
           }
-          if (typeof value.xl !== 'undefined' && (value.xl === 'start' || value.xl === 'end')) {
+          if (value.xl !== undefined && (value.xl === 'start' || value.xl === 'end')) {
             return true
           }
-          if (typeof value.xxl !== 'undefined' && (value.xxl === 'start' || value.xxl === 'end')) {
+          if (value.xxl !== undefined && (value.xxl === 'start' || value.xxl === 'end')) {
             return true
           }
           return false
diff --git a/packages/coreui-vue/src/components/dropdown/CDropdownMenu.ts b/packages/coreui-vue/src/components/dropdown/CDropdownMenu.ts
@@ -22,7 +22,7 @@ const CDropdownMenu = defineComponent({
 
     const { autoClose, alignment, dark, popper } = config
 
-    // eslint-disable-next-line @typescript-eslint/ban-types
+    // eslint-disable-next-line @typescript-eslint/ban-types, unicorn/consistent-function-scoping
     const alignmentClassNames = (alignment: object | string) => {
       const classNames: string[] = []
       if (typeof alignment === 'object') {
diff --git a/packages/coreui-vue/src/components/nav/CNavGroup.ts b/packages/coreui-vue/src/components/nav/CNavGroup.ts
@@ -63,19 +63,23 @@ const CNavGroup = defineComponent({
       navGroupRef.value.classList.add('show')
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleEnter = (el: RendererElement, done: () => void) => {
       executeAfterTransition(() => done(), el as HTMLElement)
       el.style.height = `${el.scrollHeight}px`
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleAfterEnter = (el: RendererElement) => {
       el.style.height = 'auto'
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleBeforeLeave = (el: RendererElement) => {
       el.style.height = `${el.scrollHeight}px`
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleLeave = (el: RendererElement, done: () => void) => {
       executeAfterTransition(() => done(), el as HTMLElement)
       setTimeout(() => {
diff --git a/packages/coreui-vue/src/components/navbar/CNavbar.ts b/packages/coreui-vue/src/components/navbar/CNavbar.ts
@@ -85,7 +85,7 @@ const CNavbar = defineComponent({
         props.container
           ? h(
               'div',
-              { class: [`container${props.container !== true ? '-' + props.container : ''}`] },
+              { class: [`container${props.container === true ? '' : '-' + props.container}`] },
               slots.default && slots.default(),
             )
           : slots.default && slots.default(),
diff --git a/packages/coreui-vue/src/components/offcanvas/COffcanvas.ts b/packages/coreui-vue/src/components/offcanvas/COffcanvas.ts
@@ -127,11 +127,13 @@ const COffcanvas = defineComponent({
       offcanvasRef.value.focus()
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleLeave = (el: RendererElement, done: () => void) => {
       executeAfterTransition(() => done(), el as HTMLElement)
       el.classList.add('hiding')
     }
 
+    // eslint-disable-next-line unicorn/consistent-function-scoping
     const handleAfterLeave = (el: RendererElement) => {
       el.classList.remove('show', 'hiding')
     }
diff --git a/packages/coreui-vue/src/directives/v-c-popover.ts b/packages/coreui-vue/src/directives/v-c-popover.ts
@@ -14,6 +14,7 @@ const createPopoverElement = (id: string, header: string, content: string): HTML
   return popover
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const addPopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
   document.body.appendChild(popover)
   createPopper(el, popover, popperOptions)
@@ -25,10 +26,11 @@ const addPopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptio
 const removePopoverElement = (popover: HTMLDivElement) => {
   popover.classList.remove('show')
   setTimeout(() => {
-    document.body.removeChild(popover)
+    popover.remove()
   }, 300)
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const togglePopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
   const popperElement = document.getElementById(popover.id)
   if (popperElement && popperElement.classList.contains('show')) {
diff --git a/packages/coreui-vue/src/directives/v-c-tooltip.ts b/packages/coreui-vue/src/directives/v-c-tooltip.ts
@@ -13,6 +13,7 @@ const createTooltipElement = (id: string, content: string): HTMLDivElement => {
   return tooltip
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const addTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
   document.body.appendChild(tooltip)
   createPopper(el, tooltip, popperOptions)
@@ -24,10 +25,11 @@ const addTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptio
 const removeTooltipElement = (tooltip: HTMLDivElement) => {
   tooltip.classList.remove('show')
   setTimeout(() => {
-    document.body.removeChild(tooltip)
+    tooltip.remove()
   }, 300)
 }
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const toggleTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
   const popperElement = document.getElementById(tooltip.id)
   if (popperElement && popperElement.classList.contains('show')) {

Original file line number	Diff line number	Diff line change
`@@ -19,22 +19,22 @@ const CDropdown = defineComponent({`
`19`	`19`	`if (value === 'start' \|\| value === 'end') {`
`20`	`20`	`return true`
`21`	`21`	`} else {`
`22`		`- if (typeof value.xs !== 'undefined' && (value.xs === 'start' \|\| value.xs === 'end')) {`
	`22`	`+ if (value.xs !== undefined && (value.xs === 'start' \|\| value.xs === 'end')) {`
`23`	`23`	`return true`
`24`	`24`	`}`
`25`		`- if (typeof value.sm !== 'undefined' && (value.sm === 'start' \|\| value.sm === 'end')) {`
	`25`	`+ if (value.sm !== undefined && (value.sm === 'start' \|\| value.sm === 'end')) {`
`26`	`26`	`return true`
`27`	`27`	`}`
`28`		`- if (typeof value.md !== 'undefined' && (value.md === 'start' \|\| value.md === 'end')) {`
	`28`	`+ if (value.md !== undefined && (value.md === 'start' \|\| value.md === 'end')) {`
`29`	`29`	`return true`
`30`	`30`	`}`
`31`		`- if (typeof value.lg !== 'undefined' && (value.lg === 'start' \|\| value.lg === 'end')) {`
	`31`	`+ if (value.lg !== undefined && (value.lg === 'start' \|\| value.lg === 'end')) {`
`32`	`32`	`return true`
`33`	`33`	`}`
`34`		`- if (typeof value.xl !== 'undefined' && (value.xl === 'start' \|\| value.xl === 'end')) {`
	`34`	`+ if (value.xl !== undefined && (value.xl === 'start' \|\| value.xl === 'end')) {`
`35`	`35`	`return true`
`36`	`36`	`}`
`37`		`- if (typeof value.xxl !== 'undefined' && (value.xxl === 'start' \|\| value.xxl === 'end')) {`
	`37`	`+ if (value.xxl !== undefined && (value.xxl === 'start' \|\| value.xxl === 'end')) {`
`38`	`38`	`return true`
`39`	`39`	`}`
`40`	`40`	`return false`
Original file line number	Diff line number	Diff line change
`@@ -63,19 +63,23 @@ const CNavGroup = defineComponent({`
`63`	`63`	`navGroupRef.value.classList.add('show')`
`64`	`64`	`}`
`65`	`65`
	`66`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`66`	`67`	`const handleEnter = (el: RendererElement, done: () => void) => {`
`67`	`68`	`executeAfterTransition(() => done(), el as HTMLElement)`
`68`	`69`	el.style.height = `${el.scrollHeight}px`
`69`	`70`	`}`
`70`	`71`
	`72`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`71`	`73`	`const handleAfterEnter = (el: RendererElement) => {`
`72`	`74`	`el.style.height = 'auto'`
`73`	`75`	`}`
`74`	`76`
	`77`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`75`	`78`	`const handleBeforeLeave = (el: RendererElement) => {`
`76`	`79`	el.style.height = `${el.scrollHeight}px`
`77`	`80`	`}`
`78`	`81`
	`82`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`79`	`83`	`const handleLeave = (el: RendererElement, done: () => void) => {`
`80`	`84`	`executeAfterTransition(() => done(), el as HTMLElement)`
`81`	`85`	`setTimeout(() => {`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ const CNavbar = defineComponent({`
`85`	`85`	`props.container`
`86`	`86`	`? h(`
`87`	`87`	`'div',`
`88`		- { class: [`container${props.container !== true ? '-' + props.container : ''}`] },
	`88`	+ { class: [`container${props.container === true ? '' : '-' + props.container}`] },
`89`	`89`	`slots.default && slots.default(),`
`90`	`90`	`)`
`91`	`91`	`: slots.default && slots.default(),`
Original file line number	Diff line number	Diff line change
`@@ -127,11 +127,13 @@ const COffcanvas = defineComponent({`
`127`	`127`	`offcanvasRef.value.focus()`
`128`	`128`	`}`
`129`	`129`
	`130`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`130`	`131`	`const handleLeave = (el: RendererElement, done: () => void) => {`
`131`	`132`	`executeAfterTransition(() => done(), el as HTMLElement)`
`132`	`133`	`el.classList.add('hiding')`
`133`	`134`	`}`
`134`	`135`
	`136`	`+ // eslint-disable-next-line unicorn/consistent-function-scoping`
`135`	`137`	`const handleAfterLeave = (el: RendererElement) => {`
`136`	`138`	`el.classList.remove('show', 'hiding')`
`137`	`139`	`}`