refactor(SidebarNavLink): add INavData type to items, cleanup

Author: xidedix

projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.ts

@@ -1,9 +1,11 @@
 import {Component, EventEmitter, Input, OnDestroy, OnInit, Output} from '@angular/core';
-import {SidebarNavHelper} from '../app-sidebar-nav.service';
 import {NavigationEnd, Router} from '@angular/router';
 import {Observable, Subscription} from 'rxjs';
 import {filter} from 'rxjs/operators';
 
+import {SidebarNavHelper} from '../app-sidebar-nav.service';
+import {INavData} from '../app-sidebar-nav';
+
 @Component({
   selector: 'app-sidebar-nav-link-content, cui-sidebar-nav-link-content',
   template: `
@@ -30,13 +32,13 @@ export class AppSidebarNavLinkContentComponent {
 })
 export class AppSidebarNavLinkComponent implements OnInit, OnDestroy {
 
-  protected _item: any;
+  protected _item: INavData;
 
   @Input()
-  set item(item: any) {
+  set item(item: INavData) {
     this._item = JSON.parse(JSON.stringify(item));
   }
-  get item(): any {
+  get item(): INavData {
     return this._item;
   }
 
@@ -45,6 +47,7 @@ export class AppSidebarNavLinkComponent implements OnInit, OnDestroy {
   public linkType: string;
   public href: string;
   public linkActive: boolean;
+  private url: string;
 
   private navigationEndObservable: Observable<NavigationEnd>;
   private navSubscription: Subscription;
@@ -60,12 +63,13 @@ export class AppSidebarNavLinkComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit() {
+    this.url = typeof this.item.url === 'string' ? this.item.url : this.router.serializeUrl(this.router.createUrlTree(this.item.url)) ;
     this.linkType = this.getLinkType();
-    this.href = this.isDisabled() ? '' : (this.item.href || this.item.url);
-    this.linkActive = this.router.url.split(/[?#(]/)[0] === this.item.url.split(/[?#(]/)[0];
+    this.href = this.isDisabled() ? '' : (this.item.href || this.url);
+    this.linkActive = this.router.url.split(/[?#(;]/)[0] === this.href.split(/[?#(;]/)[0];
     this.navSubscription = this.navigationEndObservable.subscribe(event => {
-      const itemUrlArray = this.item.url.split(/[?#(]/)[0].split('/');
-      const urlArray = event.urlAfterRedirects.split(/[?#(]/)[0].split('/');
+      const itemUrlArray = this.href.split(/[?#(;]/)[0].split('/');
+      const urlArray = event.urlAfterRedirects.split(/[?#(;]/)[0].split('/');
       this.linkActive = itemUrlArray.every((value, index) => value === urlArray[index]);
     });
   }
@@ -83,8 +87,7 @@ export class AppSidebarNavLinkComponent implements OnInit, OnDestroy {
   }
 
   public isExternalLink() {
-    const linkPath = Array.isArray(this.item.url) ? this.item.url[0] : this.item.url;
-    return !!this.item.href || linkPath.substring(0, 4) === 'http';
+    return !!this.item.href || this.url.substring(0, 4) === 'http';
   }
 
   linkClicked() {