all: use errors.New instead of fmt.Errorf

...if there are no %-style arguments.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Author: kolyshkin

daemon/watchdog.go

@@ -15,6 +15,7 @@
 package daemon
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"strconv"
@@ -54,7 +55,7 @@ func SdWatchdogEnabled(unsetEnvironment bool) (time.Duration, error) {
 		return 0, fmt.Errorf("error converting WATCHDOG_USEC: %w", err)
 	}
 	if s <= 0 {
-		return 0, fmt.Errorf("error WATCHDOG_USEC must be a positive number")
+		return 0, errors.New("error WATCHDOG_USEC must be a positive number")
 	}
 	interval := time.Duration(s) * time.Microsecond
 

login1/dbus.go

@@ -17,6 +17,7 @@ package login1
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"os"
 	"strconv"
@@ -186,7 +187,7 @@ func (c *Conn) GetActiveSession() (dbus.ObjectPath, error) {
 // GetSessionUser may be used to get the user of specific session
 func (c *Conn) GetSessionUser(sessionPath dbus.ObjectPath) (*User, error) {
 	if len(sessionPath) == 0 {
-		return nil, fmt.Errorf("empty sessionPath")
+		return nil, errors.New("empty sessionPath")
 	}
 
 	activeSessionObj := c.conn.Object(dbusDest, sessionPath)
@@ -224,7 +225,7 @@ func (c *Conn) GetSessionUser(sessionPath dbus.ObjectPath) (*User, error) {
 // GetSessionDisplay may be used to get the display for specific session
 func (c *Conn) GetSessionDisplay(sessionPath dbus.ObjectPath) (string, error) {
 	if len(sessionPath) == 0 {
-		return "", fmt.Errorf("empty sessionPath")
+		return "", errors.New("empty sessionPath")
 	}
 	sessionObj := c.conn.Object(dbusDest, sessionPath)
 	display, err := sessionObj.GetProperty(dbusDest + ".Session.Display")

sdjournal/journal.go

@@ -796,7 +796,7 @@ func (j *Journal) GetEntry() (*JournalEntry, error) {
 		msg := C.GoStringN((*C.char)(d), C.int(l))
 		kv := strings.SplitN(msg, "=", 2)
 		if len(kv) < 2 {
-			return nil, fmt.Errorf("failed to parse field")
+			return nil, errors.New("failed to parse field")
 		}
 
 		entry.Fields[kv[0]] = kv[1]
@@ -1102,7 +1102,7 @@ func (j *Journal) GetUniqueValues(field string) ([]string, error) {
 		msg := C.GoStringN((*C.char)(d), C.int(l))
 		kv := strings.SplitN(msg, "=", 2)
 		if len(kv) < 2 {
-			return nil, fmt.Errorf("failed to parse field")
+			return nil, errors.New("failed to parse field")
 		}
 
 		result = append(result, kv[1])

sdjournal/read.go

@@ -258,7 +258,7 @@ process:
 func simpleMessageFormatter(entry *JournalEntry) (string, error) {
 	msg, ok := entry.Fields["MESSAGE"]
 	if !ok {
-		return "", fmt.Errorf("no MESSAGE field present in journal entry")
+		return "", errors.New("no MESSAGE field present in journal entry")
 	}
 
 	usec := entry.RealtimeTimestamp

unit/deserialize.go

@@ -94,8 +94,7 @@ func deserializeAll(f io.Reader) ([]*UnitSection, []*UnitOption, error) {
 
 				// sanity check. "should not happen" as sectionKind is first in code flow.
 				if len(sections) == 0 {
-					return nil, nil, fmt.Errorf(
-						"Unit file misparse: option before section")
+					return nil, nil, errors.New("unit file misparse: option before section")
 				}
 
 				// add to newest section entries.

util/util.go

@@ -19,12 +19,12 @@
 package util
 
 import (
-	"fmt"
+	"errors"
 	"os"
 	"strings"
 )
 
-var ErrNoCGO = fmt.Errorf("go-systemd built with CGO disabled")
+var ErrNoCGO = errors.New("go-systemd built with CGO disabled")
 
 // GetRunningSlice attempts to retrieve the name of the systemd slice in which
 // the current process is running.