Deactivating an audio session that has running I/O. All I/O should be stopped or paused prior to deactivating the audio session

[numerized]

Please read first!

Please use Public Google Group (mailing list) for general technical discussions and questions.

• I have used Google with the error message or bug in association with the library and Cordova words to make sure the issue I'm reporting is only related to iOSRTC.
• I have provided steps to reproduce (e.g. sample code or updated extra/renderer-and-libwebrtc-tests.js file).
• I have provided third party library name and version, ios, Xcode and plugin version and adapter.js version if used.

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.

Versions affected

• Cordova version (e.g 7.1.0): latest
• Cordova iOS version (e.g 5.1.0): latest
• Plugin version (e.g 6.0.12): 6.latest
• iOS version (e.g 10.2): 14
• Xcode version (e.g 11.1 - 11A1027):12
• WebRTC-adapter version (e.g. 7.4.0): latest
• WebRTC Framework version (e.g. JSSip 3.1.2): RTCmulticonnection

Description

We are developing a webrtc communication tool + local recording with cordova-plugin-media, when we establish a connection with 2 peers and we start a recording those two peers stay on the line all works fine, we can start and stop many recordings it's all dealt very well with cordova-plugin-media and cordova-plugin-iosrtc.

Once one peer is leaving during the recording we have an issue:
[avas] AVAudioSession_iOS.mm:1149 Deactivating an audio session that has running I/O. All I/O should be stopped or paused prior to deactivating the audio session.

This stops the recording of the one that stays in the room, it shouldn't.

Steps to reproduce

Record a cordova-plugin-media on both device while in a call and make one peer disconnect while recording

Expected results

The peer that stays in the call should be kept recording

Actual results

The peer that stays on the call has his recording stopped gracefully by this "Deactivating an audio session that has running I/O. All I/O should be stopped or paused prior to deactivating the audio session."

I've checked the code and I don't see where there's any deactivating of audio session, it looks good to me:

This is where I looked:

do {
			let audioSession: AVAudioSession = AVAudioSession.sharedInstance()
			try audioSession.setCategory(
				PluginRTCAudioController.audioCategory,
				mode: PluginRTCAudioController.audioMode,
				options: PluginRTCAudioController.audioCategoryOptions
			)
		} catch {
			NSLog("PluginRTCAudioController#setCategory() | ERROR \(error)")
		};

[numerized]

Hope you can help on this @hthetiot, it's really key in our business model, we can make a donation too.
Would love to be in touch with you directly sometimes to be guided to submit PRs.

[hthetiot]

Thank you for report @numerized , I think the issue is that WebRTC.Framework controls the audio "recording" used for streaming, that also why you only get permissions once peer connect and not when stream start.

I will investigate the WebRTC.Framework source to see what can be done.

If you need help to make PR:

1. Fork this repository
2. Clone your fork
3. make a new branch
4. make changes and commit then push on your fork
5. Using Github create a "Pull Request" for me to merge your changes using the Github UI

[numerized]

ok I see, I can see track stops and then this All I/O should be stopped or paused prior to deactivating the audio session. I was trying a lot of little hacks to not stop tracks and make iOS think it's still going but no success so far.

Thanks for the PR How-To

[numerized]

Hi Thierry, do you have a little idea where I can start to fix this ?
Really need to get this done in the next days all the previous attempts are not successful.
Any help is welcome.

[hthetiot]

(my name is Harold not Thierry ;)

@numerized You need to get the WebRTC.Framework source code and make the fixes there.
You can find more information to build WebRTC.Framework here: https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/docs/BuildingLibWebRTC.md

I would also invite you to test M79 and M87 WebRTC build here, they may already include the fix you looking for:

• update WebRTC.framework to M87 #545
• update WebRTC.framework to M79 #475

[hthetiot]

@numerized feel free to contact me at "hthetiot at sylaps.com" if you think you need consulting to implement your fix.

[numerized]

Hi Harold,

(me and names...)

Thanks for your feedback, I'm going to try this next weekend once back to work!
I'll let you know if I need consulting on this one!

[hthetiot]

@numerized I did merge master on #545 and #475 to get all the last fixes also on those WebRTC.framework updates.

[numerized]

That's really cool, I'll let you know if those are solving our issue. Thanks

[numerized]

I've tried the latest 8 branch

cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 --verbose

removed cordova ios and added back

The issue is still present.
I'll write you an email real quick

[numerized]

I have found a workaround, therefore I'm closing this for now.

I now detect that the audio session has changed, when it changes I check how many people are on the call, if the number of people on the call is 0 and the room is in a recording, I stop and start gracefully another recording, then app does its magic and all works fine.