feat(config): return multiple errors in Validate

Author: muthukrishnan24

cmd/callback.go

@@ -53,10 +53,10 @@ func configCreate(onlyEnabled bool) error {
 }
 
 // configCheck is the callback function for check/verify command
-func configCheck(confPath string) error {
+func configCheck(confPath string) []error {
 	conf, err := config.Parse(confPath)
 	if err != nil {
-		return err
+		return []error{err}
 	}
 	return config.Validate(conf)
 }

cmd/cmd.go

@@ -124,12 +124,16 @@ func configCmd() *cli.Command {
 		},
 		Action: func(ctx *cli.Context) error {
 			confFile := ctx.String("config")
-			err := configCheck(confFile)
-			if err != nil {
-				return err
+			errs := configCheck(confFile)
+			if len(errs) == 0 {
+				fmt.Printf("%s config is valid\n", confFile)
+				return nil
 			}
-			fmt.Printf("%s config is valid\n", confFile)
-			return nil
+			if len(errs) == 1 {
+				return errs[0]
+			}
+			merr := multiError(errs)
+			return &merr
 		},
 	}
 

cmd/errors.go

@@ -0,0 +1,21 @@
+package cmd
+
+import "strings"
+
+type multiError []error
+
+func (m *multiError) Error() string {
+	errs := make([]string, len(*m))
+	for i, err := range *m {
+		errs[i] = err.Error()
+	}
+	return strings.Join(errs, "\n")
+}
+
+func (m *multiError) Errors() []error {
+	errs := make([]error, len(*m))
+	for _, err := range *m {
+		errs = append(errs, err)
+	}
+	return errs
+}

config/config.go

@@ -83,14 +83,16 @@ func Parse(confPath string) (*lint.Config, error) {
 }
 
 // Validate validates given config
-func Validate(conf *lint.Config) error {
-	if conf.Formatter == "" {
-		return errors.New("formatter is empty")
-	}
+func Validate(conf *lint.Config) []error {
+	var errs []error
 
-	_, ok := globalRegistry.GetFormatter(conf.Formatter)
-	if !ok {
-		return fmt.Errorf("unknown formatter '%s'", conf.Formatter)
+	if conf.Formatter == "" {
+		errs = append(errs, errors.New("formatter is empty"))
+	} else {
+		_, ok := globalRegistry.GetFormatter(conf.Formatter)
+		if !ok {
+			errs = append(errs, fmt.Errorf("unknown formatter '%s'", conf.Formatter))
+		}
 	}
 
 	for ruleName, r := range conf.Rules {
@@ -99,22 +101,22 @@ func Validate(conf *lint.Config) error {
 		case lint.SeverityError:
 		case lint.SeverityWarn:
 		default:
-			return fmt.Errorf("unknown severity level '%s' for rule '%s'", r.Severity, ruleName)
+			errs = append(errs, fmt.Errorf("unknown severity level '%s' for rule '%s'", r.Severity, ruleName))
 		}
 
 		// Check if rule is registered
 		ruleData, ok := globalRegistry.GetRule(ruleName)
 		if !ok {
-			return fmt.Errorf("unknown rule '%s'", ruleName)
+			errs = append(errs, fmt.Errorf("unknown rule '%s'", ruleName))
+			continue
 		}
 
 		err := ruleData.Apply(r.Argument, r.Flags)
 		if err != nil {
-			return err
+			errs = append(errs, err)
 		}
 	}
-
-	return nil
+	return errs
 }
 
 // WriteConfToFile util func to write config object to given file