Skip to content

Commit 5a8648e

Browse files
refactor: check isHeaderErr outside Parser
1 parent ebb158d commit 5a8648e

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lint/linter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ func NewLinter(conf *Config, rules []Rule) (*Linter, error) {
1414

1515
// Lint checks the given commitMsg string against rules
1616
func (l *Linter) Lint(commitMsg string) (*Result, error) {
17-
msg, isHeaderErr, err := Parse(commitMsg)
17+
msg, err := Parse(commitMsg)
1818
if err != nil {
19-
if isHeaderErr {
19+
if isHeaderErr(err) {
2020
return l.headerErrorRule(commitMsg), nil
2121
}
2222
return nil, err

lint/parse.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import (
44
"github.com/conventionalcommit/parser"
55
)
66

7-
// Parse parses given msg and checks for header error
8-
func Parse(msg string) (*Commit, bool, error) {
9-
commit, err := parser.Parse(msg)
10-
if err != nil {
11-
return nil, parser.IsHeaderErr(err), err
12-
}
13-
return commit, false, nil
7+
// Parse parses given commit message
8+
func Parse(msg string) (*Commit, error) {
9+
return parser.Parse(msg)
10+
}
11+
12+
func isHeaderErr(err error) bool {
13+
return parser.IsHeaderErr(err)
1414
}

0 commit comments

Comments
 (0)