refactor: add Severity type, move severity constants

Author: muthukrishnan24

lint/config.go

@@ -1,11 +1,5 @@
 package lint
 
-// Rule Severity Constants
-const (
-	SeverityWarn  = "warn"
-	SeverityError = "error"
-)
-
 // Config represent linter config
 type Config struct {
 	Formatter string                `yaml:"formatter"`
@@ -15,7 +9,7 @@ type Config struct {
 // RuleConfig represent config for a rule
 type RuleConfig struct {
 	Enabled  bool        `yaml:"enabled"`
-	Severity string      `yaml:"severity"`
+	Severity Severity    `yaml:"severity"`
 	Argument interface{} `yaml:"argument"`
 
 	// Optional flags

lint/constants.go

@@ -0,0 +1,20 @@
+package lint
+
+// Rule Severity Constants
+const (
+	SeverityWarn  Severity = "warn"
+	SeverityError Severity = "error"
+)
+
+type Severity string
+
+func (s Severity) String() string {
+	switch s {
+	case SeverityError:
+		return "Error"
+	case SeverityWarn:
+		return "Warning"
+	default:
+		return "Severity(" + string(s) + ")"
+	}
+}

lint/result.go

@@ -11,7 +11,7 @@ type Result struct {
 // RuleResult holds result of a linter rule
 type RuleResult struct {
 	Name     string
-	Severity string
+	Severity Severity
 	Message  string
 }