refactor(lint)!: rule.Apply accept RuleSetting

muthukrishnan24 · muthukrishnan24 · commit 03ff16b35f48 · 2022-02-18T19:33:50.000+05:30
diff --git a/config/config.go b/config/config.go
@@ -83,15 +83,15 @@ func Validate(conf *lint.Config) []error {
 		}
 	}
 
-	for ruleName, r := range conf.Settings {
+	for ruleName, ruleSetting := range conf.Settings {
 		// Check if rule is registered
 		ruleData, ok := registry.GetRule(ruleName)
 		if !ok {
 			errs = append(errs, fmt.Errorf("unknown rule '%s'", ruleName))
 			continue
 		}
 
-		err := ruleData.Apply(r.Argument, r.Flags)
+		err := ruleData.Apply(ruleSetting)
 		if err != nil {
 			errs = append(errs, err)
 		}
diff --git a/config/lint.go b/config/lint.go
@@ -53,7 +53,7 @@ func GetEnabledRules(conf *lint.Config) ([]lint.Rule, error) {
 			return nil, fmt.Errorf("config error: '%s' rule settings not found", ruleName)
 		}
 
-		err := r.Apply(rConf.Argument, rConf.Flags)
+		err := r.Apply(rConf)
 		if err != nil {
 			return nil, fmt.Errorf("config error: %v", err)
 		}
diff --git a/lint/lint.go b/lint/lint.go
@@ -50,7 +50,7 @@ type Rule interface {
 	// Apply calls with arguments and flags for the rule from config file
 	// if flags or arguments are invalid or not expected return an error
 	// Apply is called before Validate
-	Apply(arg interface{}, flags map[string]interface{}) error
+	Apply(setting RuleSetting) error
 
 	// Validate validates the rule for given commit message
 	// if given commit is valid, return true and messages slice are ignored
diff --git a/rule/charset.go b/rule/charset.go
@@ -26,8 +26,8 @@ func (r *ScopeCharsetRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *ScopeCharsetRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setStringArg(&r.Charset, arg)
+func (r *ScopeCharsetRule) Apply(setting lint.RuleSetting) error {
+	err := setStringArg(&r.Charset, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -53,8 +53,8 @@ func (r *TypeCharsetRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *TypeCharsetRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setStringArg(&r.Charset, arg)
+func (r *TypeCharsetRule) Apply(setting lint.RuleSetting) error {
+	err := setStringArg(&r.Charset, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
diff --git a/rule/enum.go b/rule/enum.go
@@ -36,13 +36,13 @@ func (r *ScopeEnumRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *ScopeEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setStringArrArg(&r.Scopes, arg)
+func (r *ScopeEnumRule) Apply(setting lint.RuleSetting) error {
+	err := setStringArrArg(&r.Scopes, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
 
-	allowEmpty, ok := flags["allow-empty"]
+	allowEmpty, ok := setting.Flags["allow-empty"]
 	if ok {
 		err := setBoolArg(&r.AllowEmpty, allowEmpty)
 		if err != nil {
@@ -74,8 +74,8 @@ func (r *TypeEnumRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *TypeEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setStringArrArg(&r.Types, arg)
+func (r *TypeEnumRule) Apply(setting lint.RuleSetting) error {
+	err := setStringArrArg(&r.Types, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -111,8 +111,8 @@ func (r *FooterEnumRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *FooterEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setStringArrArg(&r.Tokens, arg)
+func (r *FooterEnumRule) Apply(setting lint.RuleSetting) error {
+	err := setStringArrArg(&r.Tokens, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
diff --git a/rule/max_length.go b/rule/max_length.go
@@ -20,8 +20,8 @@ func (r *HeadMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *HeadMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *HeadMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -42,8 +42,8 @@ func (r *BodyMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *BodyMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *BodyMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -64,8 +64,8 @@ func (r *FooterMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *FooterMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *FooterMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -86,8 +86,8 @@ func (r *TypeMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *TypeMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *TypeMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -108,8 +108,8 @@ func (r *ScopeMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *ScopeMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *ScopeMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -130,8 +130,8 @@ func (r *DescriptionMaxLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *DescriptionMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *DescriptionMaxLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
diff --git a/rule/max_line_length.go b/rule/max_line_length.go
@@ -21,8 +21,8 @@ func (r *BodyMaxLineLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *BodyMaxLineLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *BodyMaxLineLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -43,8 +43,8 @@ func (r *FooterMaxLineLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *FooterMaxLineLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *FooterMaxLineLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
diff --git a/rule/min_length.go b/rule/min_length.go
@@ -20,8 +20,8 @@ func (r *HeadMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *HeadMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *HeadMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -42,8 +42,8 @@ func (r *BodyMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *BodyMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *BodyMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -64,8 +64,8 @@ func (r *FooterMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *FooterMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *FooterMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -86,8 +86,8 @@ func (r *TypeMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *TypeMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *TypeMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -108,8 +108,8 @@ func (r *ScopeMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *ScopeMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *ScopeMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}
@@ -130,8 +130,8 @@ func (r *DescriptionMinLenRule) Validate(msg *lint.Commit) ([]string, bool) {
 }
 
 // Apply sets the needed argument for the rule
-func (r *DescriptionMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {
-	err := setIntArg(&r.CheckLen, arg)
+func (r *DescriptionMinLenRule) Apply(setting lint.RuleSetting) error {
+	err := setIntArg(&r.CheckLen, setting.Argument)
 	if err != nil {
 		return errInvalidArg(r.Name(), err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -83,15 +83,15 @@ func Validate(conf *lint.Config) []error {`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`
`86`		`- for ruleName, r := range conf.Settings {`
	`86`	`+ for ruleName, ruleSetting := range conf.Settings {`
`87`	`87`	`// Check if rule is registered`
`88`	`88`	`ruleData, ok := registry.GetRule(ruleName)`
`89`	`89`	`if !ok {`
`90`	`90`	`errs = append(errs, fmt.Errorf("unknown rule '%s'", ruleName))`
`91`	`91`	`continue`
`92`	`92`	`}`
`93`	`93`
`94`		`- err := ruleData.Apply(r.Argument, r.Flags)`
	`94`	`+ err := ruleData.Apply(ruleSetting)`
`95`	`95`	`if err != nil {`
`96`	`96`	`errs = append(errs, err)`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func GetEnabledRules(conf *lint.Config) ([]lint.Rule, error) {`
`53`	`53`	`return nil, fmt.Errorf("config error: '%s' rule settings not found", ruleName)`
`54`	`54`	`}`
`55`	`55`
`56`		`- err := r.Apply(rConf.Argument, rConf.Flags)`
	`56`	`+ err := r.Apply(rConf)`
`57`	`57`	`if err != nil {`
`58`	`58`	`return nil, fmt.Errorf("config error: %v", err)`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ func (r ScopeCharsetRule) Validate(msg lint.Commit) ([]string, bool) {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`// Apply sets the needed argument for the rule`
`29`		`-func (r *ScopeCharsetRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`30`		`- err := setStringArg(&r.Charset, arg)`
	`29`	`+func (r *ScopeCharsetRule) Apply(setting lint.RuleSetting) error {`
	`30`	`+ err := setStringArg(&r.Charset, setting.Argument)`
`31`	`31`	`if err != nil {`
`32`	`32`	`return errInvalidArg(r.Name(), err)`
`33`	`33`	`}`
`@@ -53,8 +53,8 @@ func (r TypeCharsetRule) Validate(msg lint.Commit) ([]string, bool) {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`// Apply sets the needed argument for the rule`
`56`		`-func (r *TypeCharsetRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`57`		`- err := setStringArg(&r.Charset, arg)`
	`56`	`+func (r *TypeCharsetRule) Apply(setting lint.RuleSetting) error {`
	`57`	`+ err := setStringArg(&r.Charset, setting.Argument)`
`58`	`58`	`if err != nil {`
`59`	`59`	`return errInvalidArg(r.Name(), err)`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,13 +36,13 @@ func (r ScopeEnumRule) Validate(msg lint.Commit) ([]string, bool) {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`// Apply sets the needed argument for the rule`
`39`		`-func (r *ScopeEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`40`		`- err := setStringArrArg(&r.Scopes, arg)`
	`39`	`+func (r *ScopeEnumRule) Apply(setting lint.RuleSetting) error {`
	`40`	`+ err := setStringArrArg(&r.Scopes, setting.Argument)`
`41`	`41`	`if err != nil {`
`42`	`42`	`return errInvalidArg(r.Name(), err)`
`43`	`43`	`}`
`44`	`44`
`45`		`- allowEmpty, ok := flags["allow-empty"]`
	`45`	`+ allowEmpty, ok := setting.Flags["allow-empty"]`
`46`	`46`	`if ok {`
`47`	`47`	`err := setBoolArg(&r.AllowEmpty, allowEmpty)`
`48`	`48`	`if err != nil {`
`@@ -74,8 +74,8 @@ func (r TypeEnumRule) Validate(msg lint.Commit) ([]string, bool) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`// Apply sets the needed argument for the rule`
`77`		`-func (r *TypeEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`78`		`- err := setStringArrArg(&r.Types, arg)`
	`77`	`+func (r *TypeEnumRule) Apply(setting lint.RuleSetting) error {`
	`78`	`+ err := setStringArrArg(&r.Types, setting.Argument)`
`79`	`79`	`if err != nil {`
`80`	`80`	`return errInvalidArg(r.Name(), err)`
`81`	`81`	`}`
`@@ -111,8 +111,8 @@ func (r FooterEnumRule) Validate(msg lint.Commit) ([]string, bool) {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`// Apply sets the needed argument for the rule`
`114`		`-func (r *FooterEnumRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`115`		`- err := setStringArrArg(&r.Tokens, arg)`
	`114`	`+func (r *FooterEnumRule) Apply(setting lint.RuleSetting) error {`
	`115`	`+ err := setStringArrArg(&r.Tokens, setting.Argument)`
`116`	`116`	`if err != nil {`
`117`	`117`	`return errInvalidArg(r.Name(), err)`
`118`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ func (r HeadMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`// Apply sets the needed argument for the rule`
`23`		`-func (r *HeadMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`24`		`- err := setIntArg(&r.CheckLen, arg)`
	`23`	`+func (r *HeadMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`24`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`25`	`25`	`if err != nil {`
`26`	`26`	`return errInvalidArg(r.Name(), err)`
`27`	`27`	`}`
`@@ -42,8 +42,8 @@ func (r BodyMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// Apply sets the needed argument for the rule`
`45`		`-func (r *BodyMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`46`		`- err := setIntArg(&r.CheckLen, arg)`
	`45`	`+func (r *BodyMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`46`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`47`	`47`	`if err != nil {`
`48`	`48`	`return errInvalidArg(r.Name(), err)`
`49`	`49`	`}`
`@@ -64,8 +64,8 @@ func (r FooterMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`// Apply sets the needed argument for the rule`
`67`		`-func (r *FooterMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`68`		`- err := setIntArg(&r.CheckLen, arg)`
	`67`	`+func (r *FooterMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`68`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`69`	`69`	`if err != nil {`
`70`	`70`	`return errInvalidArg(r.Name(), err)`
`71`	`71`	`}`
`@@ -86,8 +86,8 @@ func (r TypeMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`// Apply sets the needed argument for the rule`
`89`		`-func (r *TypeMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`90`		`- err := setIntArg(&r.CheckLen, arg)`
	`89`	`+func (r *TypeMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`90`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`91`	`91`	`if err != nil {`
`92`	`92`	`return errInvalidArg(r.Name(), err)`
`93`	`93`	`}`
`@@ -108,8 +108,8 @@ func (r ScopeMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`// Apply sets the needed argument for the rule`
`111`		`-func (r *ScopeMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`112`		`- err := setIntArg(&r.CheckLen, arg)`
	`111`	`+func (r *ScopeMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`112`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`113`	`113`	`if err != nil {`
`114`	`114`	`return errInvalidArg(r.Name(), err)`
`115`	`115`	`}`
`@@ -130,8 +130,8 @@ func (r DescriptionMaxLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`// Apply sets the needed argument for the rule`
`133`		`-func (r *DescriptionMaxLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`134`		`- err := setIntArg(&r.CheckLen, arg)`
	`133`	`+func (r *DescriptionMaxLenRule) Apply(setting lint.RuleSetting) error {`
	`134`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`135`	`135`	`if err != nil {`
`136`	`136`	`return errInvalidArg(r.Name(), err)`
`137`	`137`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ func (r BodyMaxLineLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`// Apply sets the needed argument for the rule`
`24`		`-func (r *BodyMaxLineLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`25`		`- err := setIntArg(&r.CheckLen, arg)`
	`24`	`+func (r *BodyMaxLineLenRule) Apply(setting lint.RuleSetting) error {`
	`25`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`26`	`26`	`if err != nil {`
`27`	`27`	`return errInvalidArg(r.Name(), err)`
`28`	`28`	`}`
`@@ -43,8 +43,8 @@ func (r FooterMaxLineLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`// Apply sets the needed argument for the rule`
`46`		`-func (r *FooterMaxLineLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`47`		`- err := setIntArg(&r.CheckLen, arg)`
	`46`	`+func (r *FooterMaxLineLenRule) Apply(setting lint.RuleSetting) error {`
	`47`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`48`	`48`	`if err != nil {`
`49`	`49`	`return errInvalidArg(r.Name(), err)`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ func (r HeadMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`// Apply sets the needed argument for the rule`
`23`		`-func (r *HeadMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`24`		`- err := setIntArg(&r.CheckLen, arg)`
	`23`	`+func (r *HeadMinLenRule) Apply(setting lint.RuleSetting) error {`
	`24`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`25`	`25`	`if err != nil {`
`26`	`26`	`return errInvalidArg(r.Name(), err)`
`27`	`27`	`}`
`@@ -42,8 +42,8 @@ func (r BodyMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// Apply sets the needed argument for the rule`
`45`		`-func (r *BodyMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`46`		`- err := setIntArg(&r.CheckLen, arg)`
	`45`	`+func (r *BodyMinLenRule) Apply(setting lint.RuleSetting) error {`
	`46`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`47`	`47`	`if err != nil {`
`48`	`48`	`return errInvalidArg(r.Name(), err)`
`49`	`49`	`}`
`@@ -64,8 +64,8 @@ func (r FooterMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`// Apply sets the needed argument for the rule`
`67`		`-func (r *FooterMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`68`		`- err := setIntArg(&r.CheckLen, arg)`
	`67`	`+func (r *FooterMinLenRule) Apply(setting lint.RuleSetting) error {`
	`68`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`69`	`69`	`if err != nil {`
`70`	`70`	`return errInvalidArg(r.Name(), err)`
`71`	`71`	`}`
`@@ -86,8 +86,8 @@ func (r TypeMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`// Apply sets the needed argument for the rule`
`89`		`-func (r *TypeMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`90`		`- err := setIntArg(&r.CheckLen, arg)`
	`89`	`+func (r *TypeMinLenRule) Apply(setting lint.RuleSetting) error {`
	`90`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`91`	`91`	`if err != nil {`
`92`	`92`	`return errInvalidArg(r.Name(), err)`
`93`	`93`	`}`
`@@ -108,8 +108,8 @@ func (r ScopeMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`// Apply sets the needed argument for the rule`
`111`		`-func (r *ScopeMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`112`		`- err := setIntArg(&r.CheckLen, arg)`
	`111`	`+func (r *ScopeMinLenRule) Apply(setting lint.RuleSetting) error {`
	`112`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`113`	`113`	`if err != nil {`
`114`	`114`	`return errInvalidArg(r.Name(), err)`
`115`	`115`	`}`
`@@ -130,8 +130,8 @@ func (r DescriptionMinLenRule) Validate(msg lint.Commit) ([]string, bool) {`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`// Apply sets the needed argument for the rule`
`133`		`-func (r *DescriptionMinLenRule) Apply(arg interface{}, flags map[string]interface{}) error {`
`134`		`- err := setIntArg(&r.CheckLen, arg)`
	`133`	`+func (r *DescriptionMinLenRule) Apply(setting lint.RuleSetting) error {`
	`134`	`+ err := setIntArg(&r.CheckLen, setting.Argument)`
`135`	`135`	`if err != nil {`
`136`	`136`	`return errInvalidArg(r.Name(), err)`
`137`	`137`	`}`