feat: add new settings for GPU promotion (#1869)

* feat: add new settings for GPU promotion

Relates to #1591

Signed-off-by: Jeff MAURY <jmaury@redhat.com>

Author: jeffmaury

packages/backend/package.json

@@ -56,7 +56,14 @@
           "default": false,
           "description": "Display InstructLab Tuning screens (experimental)",
           "hidden": true
+        },
+        "ai-lab.showGPUPromotion": {
+          "type": "boolean",
+          "default": true,
+          "description": "Display GPU promotion banner",
+          "hidden": true
         }
+
       }
     },
     "icons": {

packages/backend/src/managers/modelsManager.spec.ts

@@ -129,6 +129,7 @@ beforeEach(() => {
     experimentalTuning: false,
     apiPort: 0,
     experimentalGPU: false,
+    showGPUPromotion: false,
   });
 
   mocks.isCompletionEventMock.mockReturnValue(true);
@@ -1016,6 +1017,7 @@ describe('uploadModelToPodmanMachine', () => {
       experimentalTuning: false,
       apiPort: 0,
       experimentalGPU: false,
+      showGPUPromotion: false,
     });
 
     const manager = new ModelsManager(

packages/backend/src/registries/ConfigurationRegistry.spec.ts

@@ -22,10 +22,11 @@ import { ConfigurationRegistry } from './ConfigurationRegistry';
 const fakeConfiguration = {
   get: vi.fn(),
   has: vi.fn(),
+  update: vi.fn(),
 } as unknown as Configuration;
 
 const webviewMock = {
-  postMessage: vi.fn(),
+  postMessage: vi.fn().mockResolvedValue(true),
 } as unknown as Webview;
 
 vi.mock('@podman-desktop/api', async () => {
@@ -58,3 +59,13 @@ test('dispose should dispose listener', () => {
   registry.dispose();
   expect(disposeMock).toHaveBeenCalled();
 });
+
+test('update should trigger configuration update', async () => {
+  const registry = new ConfigurationRegistry(webviewMock, 'appdir');
+  vi.mocked(fakeConfiguration.has).mockReturnValue(true);
+  vi.mocked(fakeConfiguration.update).mockResolvedValue(undefined);
+
+  registry.init();
+  await registry.updateExtensionConfiguration({ modelsPath: '' });
+  expect(fakeConfiguration.update).toHaveBeenCalledWith('models.path', '');
+});

packages/backend/src/registries/ConfigurationRegistry.ts

@@ -22,11 +22,12 @@ import { Messages } from '@shared/Messages';
 import path from 'node:path';
 
 const CONFIGURATION_SECTIONS: string[] = [
-  'ai-lab.models.path',
-  'ai-lab.experimentalGPU',
-  'ai-lab.apiPort',
-  'ai-lab.experimentalTuning',
-  'ai-lab.modelUploadDisabled',
+  'models.path',
+  'experimentalGPU',
+  'apiPort',
+  'experimentalTuning',
+  'modelUploadDisabled',
+  'showGPUPromotion',
 ];
 
 const API_PORT_DEFAULT = 10434;
@@ -51,9 +52,25 @@ export class ConfigurationRegistry extends Publisher<ExtensionConfiguration> imp
       apiPort: this.#configuration.get<number>('apiPort') ?? API_PORT_DEFAULT,
       experimentalTuning: this.#configuration.get<boolean>('experimentalTuning') ?? false,
       modelUploadDisabled: this.#configuration.get<boolean>('modelUploadDisabled') ?? false,
+      showGPUPromotion: this.#configuration.get<boolean>('showGPUPromotion') ?? true,
     };
   }
 
+  private getFieldName(section: string): keyof Partial<ExtensionConfiguration> {
+    return section.replace(/\.(\w)/, (match, char) => char.toUpperCase()) as keyof Partial<ExtensionConfiguration>;
+  }
+
+  async updateExtensionConfiguration(update: Partial<ExtensionConfiguration>): Promise<void> {
+    for (const section of CONFIGURATION_SECTIONS) {
+      const fieldName = this.getFieldName(section);
+      const value = update[fieldName];
+      if (value !== undefined) {
+        await this.#configuration.update(section, value);
+      }
+    }
+    this.notify(); //https://github.com/containers/podman-desktop/issues/9194
+  }
+
   private getModelsPath(): string {
     const value = this.#configuration.get<string>('models.path');
     if (value && value.length > 0) {
@@ -68,7 +85,7 @@ export class ConfigurationRegistry extends Publisher<ExtensionConfiguration> imp
 
   init(): void {
     this.#configurationDisposable = configuration.onDidChangeConfiguration(event => {
-      if (CONFIGURATION_SECTIONS.some(section => event.affectsConfiguration(section))) {
+      if (CONFIGURATION_SECTIONS.some(section => event.affectsConfiguration(`ai-lab.${section}`))) {
         this.notify();
       }
     });

packages/backend/src/studio-api-impl.ts

@@ -122,6 +122,10 @@ export class StudioApiImpl implements StudioAPI {
     return this.configurationRegistry.getExtensionConfiguration();
   }
 
+  async updateExtensionConfiguration(update: Partial<ExtensionConfiguration>): Promise<void> {
+    return this.configurationRegistry.updateExtensionConfiguration(update);
+  }
+
   async getSnippetLanguages(): Promise<Language[]> {
     return this.snippetManager.getLanguageList();
   }

packages/backend/src/workers/provider/LlamaCppPython.spec.ts

@@ -98,6 +98,7 @@ beforeEach(() => {
     apiPort: 10434,
     experimentalTuning: false,
     modelUploadDisabled: false,
+    showGPUPromotion: false,
   });
   vi.mocked(podmanConnection.findRunningContainerProviderConnection).mockReturnValue(dummyConnection);
   vi.mocked(podmanConnection.getContainerProviderConnection).mockReturnValue(dummyConnection);
@@ -277,6 +278,7 @@ describe('perform', () => {
       apiPort: 10434,
       experimentalTuning: false,
       modelUploadDisabled: false,
+      showGPUPromotion: false,
     });
 
     vi.mocked(gpuManager.collectGPUs).mockResolvedValue([
@@ -318,6 +320,7 @@ describe('perform', () => {
       apiPort: 10434,
       experimentalTuning: false,
       modelUploadDisabled: false,
+      showGPUPromotion: false,
     });
 
     vi.mocked(gpuManager.collectGPUs).mockResolvedValue([
@@ -352,6 +355,7 @@ describe('perform', () => {
       apiPort: 10434,
       experimentalTuning: false,
       modelUploadDisabled: false,
+      showGPUPromotion: false,
     });
 
     vi.mocked(gpuManager.collectGPUs).mockResolvedValue([

packages/frontend/src/lib/notification/ContainerConnectionWrapper.spec.ts

@@ -69,6 +69,7 @@ beforeEach(() => {
     experimentalTuning: false,
     modelsPath: '',
     modelUploadDisabled: false,
+    showGPUPromotion: false,
   });
 });
 

packages/frontend/src/pages/CreateService.spec.ts

@@ -154,6 +154,7 @@ beforeEach(() => {
     experimentalTuning: false,
     modelsPath: '',
     modelUploadDisabled: false,
+    showGPUPromotion: false,
   });
 
   window.HTMLElement.prototype.scrollIntoView = vi.fn();

packages/shared/src/StudioAPI.ts

@@ -177,6 +177,7 @@ export abstract class StudioAPI {
    * Get the extension configuration (preferences)
    */
   abstract getExtensionConfiguration(): Promise<ExtensionConfiguration>;
+  abstract updateExtensionConfiguration(update: Partial<ExtensionConfiguration>): Promise<void>;
 
   /**
    * Return the list of supported languages to generate code from.

packages/shared/src/models/IExtensionConfiguration.ts

@@ -22,4 +22,5 @@ export interface ExtensionConfiguration {
   apiPort: number;
   experimentalTuning: boolean;
   modelUploadDisabled: boolean;
+  showGPUPromotion: boolean;
 }