Skip to content

Commit ad82523

Browse files
committed
chore(kubevirt): Use constants for default-{instancetype,preference}
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
1 parent 2cc4be5 commit ad82523

File tree

1 file changed

+9
-5
lines changed
  • pkg/toolsets/kubevirt/vm/create

1 file changed

+9
-5
lines changed

pkg/toolsets/kubevirt/vm/create/tool.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ import (
1515
"k8s.io/utils/ptr"
1616
)
1717

18+
const (
19+
defaultInstancetypeLabel = "instancetype.kubevirt.io/default-instancetype"
20+
defaultPreferenceLabel = "instancetype.kubevirt.io/default-preference"
21+
)
22+
1823
//go:embed plan.tmpl
1924
var planTemplate string
2025

@@ -489,8 +494,8 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
489494
defaultInstancetype := ""
490495
defaultPreference := ""
491496
if labels != nil {
492-
defaultInstancetype = labels["instancetype.kubevirt.io/default-instancetype"]
493-
defaultPreference = labels["instancetype.kubevirt.io/default-preference"]
497+
defaultInstancetype = labels[defaultInstancetypeLabel]
498+
defaultPreference = labels[defaultPreferenceLabel]
494499
}
495500

496501
results = append(results, DataSourceInfo{
@@ -501,7 +506,6 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
501506
DefaultPreference: defaultPreference,
502507
})
503508
}
504-
505509
// Add common containerdisk images as well
506510
results = append(results, getDefaultContainerDisks()...)
507511

@@ -538,8 +542,8 @@ func listDataSourcesFromNamespace(params api.ToolHandlerParams, dynamicClient dy
538542
defaultInstancetype := ""
539543
defaultPreference := ""
540544
if labels != nil {
541-
defaultInstancetype = labels["instancetype.kubevirt.io/default-instancetype"]
542-
defaultPreference = labels["instancetype.kubevirt.io/default-preference"]
545+
defaultInstancetype = labels[defaultInstancetypeLabel]
546+
defaultPreference = labels[defaultPreferenceLabel]
543547
}
544548

545549
results = append(results, DataSourceInfo{

0 commit comments

Comments
 (0)