refactor(kubevirt): Extract helper functions from searchDataSources

Break down the searchDataSources function into smaller, focused helper functions:
- getDynamicClient: Handles dynamic client initialization
- collectDataSources: Collects DataSources from well-known and all namespaces
- deduplicateAndMergeDataSources: Merges and deduplicates DataSource results

This improves code readability and maintainability by following the single responsibility principle.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

Author: lyarwood

pkg/toolsets/kubevirt/vm/create/tool.go

@@ -407,20 +407,8 @@ func getDefaultContainerDisks() []DataSourceInfo {
 
 // searchDataSources searches for DataSource resources in the cluster
 func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSourceInfo, error) {
-	// Try to get dynamic client to query for DataSources
-	// Handle nil or invalid clients gracefully (e.g., in test environments)
-	if params.Kubernetes == nil {
-		// Return just the built-in containerdisk images
-		return getDefaultContainerDisks(), nil
-	}
-
-	restConfig := params.RESTConfig()
-	if restConfig == nil {
-		// Return just the built-in containerdisk images
-		return getDefaultContainerDisks(), nil
-	}
-
-	dynamicClient, err := dynamic.NewForConfig(restConfig)
+	// Get dynamic client for querying DataSources
+	dynamicClient, err := getDynamicClient(params)
 	if err != nil {
 		// Return just the built-in containerdisk images
 		return getDefaultContainerDisks(), nil
@@ -433,6 +421,43 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 		Resource: "datasources",
 	}
 
+	// Collect DataSources from well-known namespaces and all namespaces
+	results := collectDataSources(params, dynamicClient, dataSourceGVR)
+
+	// Add common containerdisk images
+	results = append(results, getDefaultContainerDisks()...)
+
+	// Return helpful message if no sources found
+	if len(results) == 0 {
+		return []DataSourceInfo{
+			{
+				Name:      "No sources available",
+				Namespace: "",
+				Source:    "No DataSources or containerdisks found",
+			},
+		}, nil
+	}
+
+	return results, nil
+}
+
+// getDynamicClient creates a dynamic Kubernetes client from the provided parameters
+func getDynamicClient(params api.ToolHandlerParams) (dynamic.Interface, error) {
+	// Handle nil or invalid clients gracefully (e.g., in test environments)
+	if params.Kubernetes == nil {
+		return nil, fmt.Errorf("kubernetes client is nil")
+	}
+
+	restConfig := params.RESTConfig()
+	if restConfig == nil {
+		return nil, fmt.Errorf("REST config is nil")
+	}
+
+	return dynamic.NewForConfig(restConfig)
+}
+
+// collectDataSources collects DataSources from well-known namespaces and all namespaces
+func collectDataSources(params api.ToolHandlerParams, dynamicClient dynamic.Interface, gvr schema.GroupVersionResource) []DataSourceInfo {
 	var results []DataSourceInfo
 
 	// Try to list DataSources from well-known namespaces first
@@ -442,20 +467,18 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 	}
 
 	for _, ns := range wellKnownNamespaces {
-		dsInfos, err := listDataSourcesFromNamespace(params, dynamicClient, dataSourceGVR, ns)
+		dsInfos, err := listDataSourcesFromNamespace(params, dynamicClient, gvr, ns)
 		if err == nil {
 			results = append(results, dsInfos...)
 		}
 	}
 
 	// List DataSources from all namespaces
-	list, err := dynamicClient.Resource(dataSourceGVR).List(params.Context, metav1.ListOptions{})
+	list, err := dynamicClient.Resource(gvr).List(params.Context, metav1.ListOptions{})
 	if err != nil {
-		// If we found DataSources from well-known namespaces but couldn't list all, continue
+		// If we found DataSources from well-known namespaces but couldn't list all, return what we have
 		if len(results) > 0 {
-			// Add common containerdisk images as well
-			results = append(results, getDefaultContainerDisks()...)
-			return results, nil
+			return results
 		}
 		// DataSources might not be available, return helpful message
 		return []DataSourceInfo{
@@ -464,18 +487,26 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 				Namespace: "",
 				Source:    "CDI may not be installed or DataSources are not available in this cluster",
 			},
-		}, nil
+		}
 	}
 
-	// Parse the results from all namespaces (this will include well-known namespaces again, but we'll deduplicate)
+	// Deduplicate and add DataSources from all namespaces
+	results = deduplicateAndMergeDataSources(results, list.Items)
+
+	return results
+}
+
+// deduplicateAndMergeDataSources merges new DataSources with existing ones, avoiding duplicates
+func deduplicateAndMergeDataSources(existing []DataSourceInfo, items []unstructured.Unstructured) []DataSourceInfo {
+	// Create a map to track already seen DataSources
 	seen := make(map[string]bool)
-	// Mark DataSources from well-known namespaces as already seen
-	for _, ds := range results {
+	for _, ds := range existing {
 		key := ds.Namespace + "/" + ds.Name
 		seen[key] = true
 	}
 
-	for _, item := range list.Items {
+	// Add new DataSources that haven't been seen
+	for _, item := range items {
 		name := item.GetName()
 		namespace := item.GetNamespace()
 		key := namespace + "/" + name
@@ -486,8 +517,6 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 		}
 
 		labels := item.GetLabels()
-
-		// Extract source information from the DataSource spec
 		source := extractDataSourceInfo(&item)
 
 		// Extract default instancetype and preference from labels
@@ -498,28 +527,16 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 			defaultPreference = labels[defaultPreferenceLabel]
 		}
 
-		results = append(results, DataSourceInfo{
+		existing = append(existing, DataSourceInfo{
 			Name:                name,
 			Namespace:           namespace,
 			Source:              source,
 			DefaultInstancetype: defaultInstancetype,
 			DefaultPreference:   defaultPreference,
 		})
 	}
-	// Add common containerdisk images as well
-	results = append(results, getDefaultContainerDisks()...)
 
-	if len(results) == 0 {
-		return []DataSourceInfo{
-			{
-				Name:      "No sources available",
-				Namespace: "",
-				Source:    "No DataSources or containerdisks found",
-			},
-		}, nil
-	}
-
-	return results, nil
+	return existing
 }
 
 // listDataSourcesFromNamespace lists DataSources from a specific namespace