feat(kubevirt): search kubevirt-os-images for DataSources

Previously, the vm_create tool only searched for DataSources in the
OpenShift-specific 'openshift-virtualization-os-images' namespace.

This change extends the search to also include the 'kubevirt-os-images'
namespace, which is commonly used in upstream KubeVirt deployments.

The logic for querying a namespace has been refactored into a helper
function to accommodate searching multiple well-known locations for
boot images.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

Author: lyarwood

pkg/toolsets/kubevirt/vm/create/tool.go

@@ -430,41 +430,23 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 
 	var results []DataSourceInfo
 
-	// Try to list DataSources from OpenShift virtualization OS images namespace first
-	openshiftNamespace := "openshift-virtualization-os-images"
-	openshiftList, err := dynamicClient.Resource(dataSourceGVR).Namespace(openshiftNamespace).List(params.Context, metav1.ListOptions{})
-	if err == nil {
-		// Parse OpenShift DataSources
-		for _, item := range openshiftList.Items {
-			name := item.GetName()
-			namespace := item.GetNamespace()
-			labels := item.GetLabels()
-
-			// Extract source information from the DataSource spec
-			source := extractDataSourceInfo(&item)
-
-			// Extract default instancetype and preference from labels
-			defaultInstancetype := ""
-			defaultPreference := ""
-			if labels != nil {
-				defaultInstancetype = labels["instancetype.kubevirt.io/default-instancetype"]
-				defaultPreference = labels["instancetype.kubevirt.io/default-preference"]
-			}
+	// Try to list DataSources from well-known namespaces first
+	wellKnownNamespaces := []string{
+		"openshift-virtualization-os-images",
+		"kubevirt-os-images",
+	}
 
-			results = append(results, DataSourceInfo{
-				Name:                name,
-				Namespace:           namespace,
-				Source:              source,
-				DefaultInstancetype: defaultInstancetype,
-				DefaultPreference:   defaultPreference,
-			})
+	for _, ns := range wellKnownNamespaces {
+		dsInfos, err := listDataSourcesFromNamespace(params, dynamicClient, dataSourceGVR, ns)
+		if err == nil {
+			results = append(results, dsInfos...)
 		}
 	}
 
 	// List DataSources from all namespaces
 	list, err := dynamicClient.Resource(dataSourceGVR).List(params.Context, metav1.ListOptions{})
 	if err != nil {
-		// If we found OpenShift DataSources but couldn't list all namespaces, continue
+		// If we found DataSources from well-known namespaces but couldn't list all, continue
 		if len(results) > 0 {
 			// Add common containerdisk images as well
 			results = append(results, getDefaultContainerDisks()...)
@@ -480,9 +462,9 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 		}, nil
 	}
 
-	// Parse the results from all namespaces (this will include OpenShift namespace again, but we'll deduplicate)
+	// Parse the results from all namespaces (this will include well-known namespaces again, but we'll deduplicate)
 	seen := make(map[string]bool)
-	// Mark OpenShift DataSources as already seen
+	// Mark DataSources from well-known namespaces as already seen
 	for _, ds := range results {
 		key := ds.Namespace + "/" + ds.Name
 		seen[key] = true
@@ -536,6 +518,42 @@ func searchDataSources(params api.ToolHandlerParams, query string) ([]DataSource
 	return results, nil
 }
 
+// listDataSourcesFromNamespace lists DataSources from a specific namespace
+func listDataSourcesFromNamespace(params api.ToolHandlerParams, dynamicClient dynamic.Interface, gvr schema.GroupVersionResource, namespace string) ([]DataSourceInfo, error) {
+	var results []DataSourceInfo
+	list, err := dynamicClient.Resource(gvr).Namespace(namespace).List(params.Context, metav1.ListOptions{})
+	if err != nil {
+		return nil, err
+	}
+
+	for _, item := range list.Items {
+		name := item.GetName()
+		ns := item.GetNamespace()
+		labels := item.GetLabels()
+
+		// Extract source information from the DataSource spec
+		source := extractDataSourceInfo(&item)
+
+		// Extract default instancetype and preference from labels
+		defaultInstancetype := ""
+		defaultPreference := ""
+		if labels != nil {
+			defaultInstancetype = labels["instancetype.kubevirt.io/default-instancetype"]
+			defaultPreference = labels["instancetype.kubevirt.io/default-preference"]
+		}
+
+		results = append(results, DataSourceInfo{
+			Name:                name,
+			Namespace:           ns,
+			Source:              source,
+			DefaultInstancetype: defaultInstancetype,
+			DefaultPreference:   defaultPreference,
+		})
+	}
+
+	return results, nil
+}
+
 // searchPreferences searches for VirtualMachineClusterPreference resources in the cluster
 func searchPreferences(params api.ToolHandlerParams) []PreferenceInfo {
 	// Handle nil or invalid clients gracefully (e.g., in test environments)