add save without changes test

Author: sokrat

EmbedsManyBehavior.php

@@ -35,10 +35,16 @@ public function getStorage()
     {
         if (empty($this->_storage)) {
             $this->_storage = new Storage();
-            foreach ((array)$this->owner->{$this->attribute} as $attributes) {
-                $model = $this->createEmbedded($attributes, false);
+
+            $attributes = (array)$this->owner->{$this->attribute};
+            if (empty($attributes) && in_array($this->owner->scenario, $this->initEmptyScenarios)) {
+                $attributes[] = [];
+            }
+
+            foreach ($attributes as $modelAttributes) {
+                $model = $this->createEmbedded($modelAttributes, false);
                 $model->setFormName($this->getFormName($this->_storage->getNextIndex()));
-                $this->_storage[] = $this->createEmbedded($attributes, false);
+                $this->_storage[] = $model;
             }
         }
         return $this->_storage;

tests/unit.suite.yml

@@ -3,4 +3,4 @@
 # suite for unit (internal) tests.
 class_name: UnitTester
 modules:
-    enabled: [Asserts, UnitHelper]
+    enabled: [Asserts]

tests/unit/EmbedsOneBehaviorTest.php

@@ -3,15 +3,15 @@
 use consultnn\embedded\tests\models\SlaveEmbeddedClass;
 
 
-class EmbedsOneBehaviorTest extends \Codeception\TestCase\Test
+class EmbedsTest extends \Codeception\TestCase\Test
 {
     /**
      * @var \UnitTester
      */
     protected $tester;
     /**
      *
-     * @var Company
+     * @var MasterTestClass
      */
     protected $company;
 
@@ -20,6 +20,27 @@ protected function _before()
         $this->company = new MasterTestClass();
         $this->company->deleteAll();
     }
+
+    public function testSaveNotChanged()
+    {
+        $data = ['_id' => 1,
+            '_one' => ['name'=>1, 'value' => 1],
+            '_many' => [
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1],
+                ['name'=>1, 'value' => 1]
+            ]
+        ];
+        $this->company->setAttributes($data, false);
+        $this->company->save();
+        $this->assertEquals($this->company->toArray(), $data);
+        $this->company->save();
+        $this->assertEquals($this->company->toArray(), $data);
+    }
 
     /**
     * @dataProvider testSaveDataProvider