DGS-22964 Ensure all deps are strongly named #2548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR ensures all dependencies are strongly named by vendoring two NuGet packages (Miscreant and HKDF.Standard) that lack strong naming, and updates Cel.NET from version 0.4.0 to 1.0.0. This addresses strong naming requirements for the Confluent.SchemaRegistry.Encryption assembly.
Key changes:
- Vendored
Miscreantv0.3.3 andHKDF.Standardv2.0.0 source code with namespace changes - Updated namespace references throughout the codebase to use vendored versions
- Upgraded
Cel.NETpackage dependency to version 1.0.0
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Confluent.SchemaRegistry.Rules.csproj | Updated Cel.NET package from 0.4.0 to 1.0.0 |
| Vendored/README.md | Added documentation explaining vendored dependencies and modifications |
| Vendored/Miscreant/*.cs | Vendored Miscreant library source with namespace changes |
| Vendored/HkdfStandard/Hkdf.cs | Simplified vendored HKDF implementation |
| Vendored//LICENSE | MIT license files for vendored dependencies |
| LocalKmsClient.cs | Updated namespace import to vendored HkdfStandard |
| KmsClients.cs | Updated namespace import to vendored Miscreant |
| Cryptor.cs | Updated namespace import to vendored Miscreant |
| Confluent.SchemaRegistry.Encryption.csproj | Removed NuGet references and added license file packaging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Confluent.SchemaRegistry.Encryption/Vendored/Miscreant/StreamDecryptor.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry.Encryption/Vendored/Miscreant/AesPmac.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry.Encryption/Vendored/Miscreant/AesPmac.cs
Outdated
Show resolved
Hide resolved
|
tobiogunbi
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR ensures all dependencies are strongly named (which is required by .NET Framework) by vendoring (copying) the source for two NuGet packages (Miscreant and HKDF.Standard) that lack strong naming.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups