Lint fixes for F, E, W, G and RSE errors (#310)

Author: IgorChvyrov-sm

src/conductor/__init__.py

@@ -1 +1 @@
-__version__ = "1.1.10"
+__version__ = "1.1.10"

src/conductor/client/automator/task_handler.py

@@ -2,7 +2,7 @@
 import importlib
 import logging
 import os
-from multiprocessing import Process, freeze_support, Queue, set_start_method, get_context
+from multiprocessing import Process, freeze_support, Queue, set_start_method
 from sys import platform
 from typing import List, Optional
 

src/conductor/client/automator/task_runner.py

@@ -60,7 +60,7 @@ def run(self) -> None:
         while True:
             try:
                 self.run_once()
-            except Exception as e:
+            except Exception:
                 pass
 
     def run_once(self) -> None:
@@ -229,14 +229,13 @@ def __set_worker_properties(self) -> None:
         if polling_interval:
             try:
                 self.worker.poll_interval = float(polling_interval)
-            except Exception as e:
+            except Exception:
                 logger.error(f'error reading and parsing the polling interval value {polling_interval}')
                 self.worker.poll_interval = self.worker.get_polling_interval_in_seconds()
 
         if polling_interval:
             try:
                 self.worker.poll_interval = float(polling_interval)
-                polling_interval_initialized = True
             except Exception as e:
                 logger.error("Exception in reading polling interval from environment variable: {0}.".format(str(e)))
 

src/conductor/client/automator/utils.py

@@ -44,7 +44,7 @@ def convert_from_dict(cls: type, data: dict) -> object:
     if data is None:
         return data
 
-    if type(data) == cls:
+    if isinstance(data, cls):
         return data
 
     if dataclasses.is_dataclass(cls):
@@ -54,7 +54,7 @@ def convert_from_dict(cls: type, data: dict) -> object:
     if not ((str(typ).startswith('dict[') or
              str(typ).startswith('typing.Dict[') or
              str(typ).startswith('requests.structures.CaseInsensitiveDict[') or
-             typ == dict or str(typ).startswith('OrderedDict['))):
+             typ is dict or str(typ).startswith('OrderedDict['))):
         data = {}
 
     members = inspect.signature(cls.__init__).parameters
@@ -82,7 +82,7 @@ def convert_from_dict(cls: type, data: dict) -> object:
         elif (str(typ).startswith('dict[') or
               str(typ).startswith('typing.Dict[') or
               str(typ).startswith('requests.structures.CaseInsensitiveDict[') or
-              typ == dict or str(typ).startswith('OrderedDict[')):
+              typ is dict or str(typ).startswith('OrderedDict[')):
 
             values = {}
             generic_type = object
@@ -92,7 +92,7 @@ def convert_from_dict(cls: type, data: dict) -> object:
                 v = data[member][k]
                 values[k] = get_value(generic_type, v)
             kwargs[member] = values
-        elif typ == inspect.Parameter.empty:
+        elif typ is inspect.Parameter.empty:
             if inspect.Parameter.VAR_KEYWORD == members[member].kind:
                 if type(data) in dict_types:
                     kwargs.update(data)
@@ -117,7 +117,7 @@ def get_value(typ: type, val: object) -> object:
             values.append(converted)
         return values
     elif str(typ).startswith('dict[') or str(typ).startswith(
-            'typing.Dict[') or str(typ).startswith('requests.structures.CaseInsensitiveDict[') or typ == dict:
+            'typing.Dict[') or str(typ).startswith('requests.structures.CaseInsensitiveDict[') or typ is dict:
         values = {}
         for k in val:
             v = val[k]

src/conductor/client/helpers/helper.py

@@ -71,7 +71,7 @@ def __deserialize(self, data, klass):
         if data is None:
             return None
 
-        if type(klass) == str:
+        if isinstance(klass, str):
             if klass.startswith('list['):
                 sub_kls = re.match(r'list\[(.*)\]', klass).group(1)
                 return [self.__deserialize(sub_data, sub_kls)
@@ -90,11 +90,11 @@ def __deserialize(self, data, klass):
 
         if klass in self.PRIMITIVE_TYPES:
             return self.__deserialize_primitive(data, klass)
-        elif klass == object:
+        elif klass is object:
             return self.__deserialize_object(data)
-        elif klass == datetime.date:
+        elif klass is datetime.date:
             return self.__deserialize_date(data)
-        elif klass == datetime.datetime:
+        elif klass is datetime.datetime:
             return self.__deserialize_datatime(data)
         else:
             return self.__deserialize_model(data, klass)
@@ -108,7 +108,7 @@ def __deserialize_primitive(self, data, klass):
         :return: int, long, float, str, bool.
         """
         try:
-            if klass == str and type(data) == bytes:
+            if isinstance(klass, str) and isinstance(data, bytes):
                 return self.__deserialize_bytes_to_str(data)
             return klass(data)
         except UnicodeEncodeError:

src/conductor/client/metadata_client.py

@@ -64,4 +64,4 @@ def set_workflow_tags(self, tags: List[MetadataTag], workflow_name: str):
         pass
 
     def delete_workflow_tag(self, tag: MetadataTag, workflow_name: str):
-        pass
+        pass

src/conductor/client/orkes/orkes_schema_client.py

@@ -1,8 +1,7 @@
-from typing import List, Optional
+from typing import List
 
 from conductor.client.configuration.configuration import Configuration
 from conductor.client.http.models.schema_def import SchemaDef
-from conductor.client.http.rest import ApiException
 from conductor.client.orkes.orkes_base_client import OrkesBaseClient
 from conductor.client.schema_client import SchemaClient
 
@@ -24,4 +23,4 @@ def delete_schema(self, schema_name: str, version: int) -> None:
         self.schemaApi.delete_schema_by_name_and_version(name=schema_name, version=version)
 
     def delete_schema_by_name(self, schema_name: str) -> None:
-        self.schemaApi.delete_schema_by_name(name=schema_name)
+        self.schemaApi.delete_schema_by_name(name=schema_name)

src/conductor/client/orkes/orkes_service_registry_client.py

@@ -67,4 +67,4 @@ def get_queue_sizes_for_all_tasks(self) -> dict:
     def is_circuit_breaker_open(self, name: str) -> bool:
         """Check if circuit breaker is open for a service"""
         status = self.get_circuit_breaker_status(name)
-        return status.current_state and status.current_state.upper() == "OPEN"
+        return status.current_state and status.current_state.upper() == "OPEN"

src/conductor/client/orkes/orkes_workflow_client.py

@@ -213,4 +213,4 @@ def update_state(self, workflow_id: str, update_requesst: WorkflowStateUpdate,
         if wait_for_seconds is not None:
             kwargs['wait_for_seconds'] = wait_for_seconds
 
-        return self.workflowResourceApi.update_workflow_and_task_state(update_requesst=update_requesst, workflow_id=workflow_id, **kwargs)
+        return self.workflowResourceApi.update_workflow_and_task_state(update_requesst=update_requesst, workflow_id=workflow_id, **kwargs)

src/conductor/client/orkes_clients.py

@@ -54,4 +54,4 @@ def get_prompt_client(self) -> PromptClient:
         return OrkesPromptClient(self.configuration)
 
     def get_schema_client(self) -> SchemaClient:
-        return OrkesSchemaClient(self.configuration)
+        return OrkesSchemaClient(self.configuration)