Fix CS

Author: Seldaek

src/Command/CleanSpamPackagesCommand.php

@@ -19,12 +19,8 @@
 use App\Model\ProviderManager;
 use Doctrine\Persistence\ManagerRegistry;
 use App\Entity\Package;
-use App\Service\Locker;
-use Psr\Log\LoggerInterface;
-use Seld\Signal\SignalHandler;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**

src/Command/IndexPackagesCommand.php

@@ -23,7 +23,6 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Doctrine\DBAL\Connection;
 use Doctrine\Persistence\ManagerRegistry;
 use App\Service\Locker;
 use Predis\Client;

src/Command/MigrateDataTypesCommand.php

@@ -12,26 +12,10 @@
 
 namespace App\Command;
 
-use App\Entity\Dist;
-use App\Entity\DistType;
-use App\Entity\Version;
-use App\Service\FallbackGitHubAuthProvider;
-use Composer\Util\HttpDownloader;
-use Doctrine\DBAL\ArrayParameterType;
 use Doctrine\Persistence\ManagerRegistry;
-use App\Entity\Package;
-use App\Package\V2Dumper;
-use App\Service\Locker;
-use Psr\Log\LoggerInterface;
-use Seld\Signal\SignalHandler;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\HttpClient\Exception\TimeoutException;
-use Symfony\Component\HttpClient\Exception\TransportException;
-use Symfony\Component\HttpClient\NoPrivateNetworkHttpClient;
-use ZipArchive;
 
 class MigrateDataTypesCommand extends Command
 {

src/Command/RunWorkersCommand.php

@@ -87,7 +87,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 try {
                     // force destructor as that will trigger another lock release attempt
                     $this->lock = null;
-                } catch (LockReleasingException) {}
+                } catch (LockReleasingException) {
+                }
             }
         }
 

src/Command/UnfreezePackageCommand.php

@@ -55,6 +55,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $package = $this->getEM()->getRepository(Package::class)->findOneBy(['name' => $name]);
         if ($package === null) {
             $output->writeln('<error>Package '.$name.' not found</error>');
+
             return 1;
         }
 

src/Command/UploadMetadataToCdnCommand.php

@@ -44,7 +44,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $verbose = (bool)$input->getOption('verbose');
+        $verbose = (bool) $input->getOption('verbose');
 
         $finder = Finder::create()
             ->in($this->webDir.'p2')

src/Controller/ApiController.php

@@ -38,7 +38,8 @@
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
-enum ApiType {
+enum ApiType
+{
     case Safe;
     case Unsafe;
 }
@@ -49,8 +50,8 @@ enum ApiType {
 class ApiController extends Controller
 {
     private const REGEXES = [
-        'gitlab'         => '{^(?:ssh://git@|https?://|git://|git@)?(?P<host>[a-z0-9.-]+)(?::[0-9]+/|[:/])(?P<path>[\w.-]+(?:/[\w.-]+?)+)(?:\.git|/)?$}i',
-        'any'            => '{^(?:ssh://git@|https?://|git://|git@)?(?P<host>[a-z0-9.-]+)(?::[0-9]+/|[:/])(?P<path>[\w.-]+(?:/[\w.-]+?)*)(?:\.git|/)?$}i',
+        'gitlab' => '{^(?:ssh://git@|https?://|git://|git@)?(?P<host>[a-z0-9.-]+)(?::[0-9]+/|[:/])(?P<path>[\w.-]+(?:/[\w.-]+?)+)(?:\.git|/)?$}i',
+        'any' => '{^(?:ssh://git@|https?://|git://|git@)?(?P<host>[a-z0-9.-]+)(?::[0-9]+/|[:/])(?P<path>[\w.-]+(?:/[\w.-]+?)*)(?:\.git|/)?$}i',
         'bitbucket_push' => '{^(?:https?://|git://|git@)?(?:api\.)?(?P<host>bitbucket\.org)[/:](?P<path>[\w.-]+/[\w.-]+?)(?:\.git)?/?$}i',
         'bitbucket_hook' => '{^(?:https?://|git://|git@)?(?P<host>bitbucket\.org)[/:](?P<path>[\w.-]+/[\w.-]+?)(?:\.git)?/?$}i',
     ];

src/Controller/ExtensionController.php

@@ -15,7 +15,6 @@
 use App\Entity\Package;
 use App\Model\DownloadManager;
 use App\Model\FavoriteManager;
-use Pagerfanta\Adapter\FixedAdapter;
 use Pagerfanta\Doctrine\ORM\QueryAdapter;
 use Pagerfanta\Pagerfanta;
 use Predis\Client as RedisClient;

src/Controller/PackageController.php

@@ -27,7 +27,6 @@
 use Composer\Semver\Constraint\Constraint;
 use Composer\Semver\Constraint\MatchNoneConstraint;
 use Composer\Semver\Constraint\MultiConstraint;
-use DateTime;
 use DateTimeImmutable;
 use Doctrine\ORM\NoResultException;
 use App\Entity\Download;
@@ -99,12 +98,12 @@ public function allAction(): RedirectResponse
     }
 
     #[Route(path: '/packages/list.json', name: 'list', defaults: ['_format' => 'json'], methods: ['GET'])]
-    public function listAction(Request $req,
+    public function listAction(
+        Request $req,
         PackageRepository $repo,
-        #[MapQueryParameter] ?string $type=null,
-        #[MapQueryParameter] ?string $vendor=null,
-    ): JsonResponse
-    {
+        #[MapQueryParameter] ?string $type = null,
+        #[MapQueryParameter] ?string $vendor = null,
+    ): JsonResponse {
         $queryParams = $req->query->all();
         $fields = (array) ($queryParams['fields'] ?? []); // support single or multiple fields
         $fields = array_intersect($fields, ['repository', 'type', 'abandoned']);
@@ -113,7 +112,7 @@ public function listAction(Request $req,
             $filters = array_filter([
                 'type' => $type,
                 'vendor' => $vendor,
-            ], fn ($val) => $val !== null);
+            ], static fn ($val) => $val !== null);
 
             $response = new JsonResponse(['packages' => $repo->getPackagesWithFields($filters, $fields)]);
             $response->setSharedMaxAge(300);
@@ -458,7 +457,7 @@ public function viewSpamAction(Request $req, CsrfTokenManagerInterface $csrfToke
     public function markSafeAction(Request $req): RedirectResponse
     {
         /** @var string[] $vendors */
-        $vendors = array_filter($req->request->all('vendor'), fn ($vendor) => $vendor !== '' && $vendor !== null);
+        $vendors = array_filter($req->request->all('vendor'), static fn ($vendor) => $vendor !== '' && $vendor !== null);
         if (!$this->isCsrfTokenValid('mark_safe', (string) $req->request->get('token'))) {
             throw new BadRequestHttpException('Invalid CSRF token');
         }
@@ -1443,7 +1442,7 @@ public function versionStatsAction(Request $req, #[MapEntity] Package $package,
         $normalizer = new VersionParser;
         try {
             $normVersion = $normalizer->normalize($version);
-        } catch (\UnexpectedValueException $e) {
+        } catch (UnexpectedValueException $e) {
             return new JsonResponse(['error' => $e->getMessage()], Response::HTTP_BAD_REQUEST);
         }
 

src/Controller/ProfileController.php

@@ -161,6 +161,7 @@ public function tokenRotateAction(Request $request, #[CurrentUser] User $user, U
     {
         if (!$this->isCsrfTokenValid('rotate_api', (string) $request->request->get('token'))) {
             $this->addFlash('error', 'Invalid csrf token, try again.');
+
             return $this->redirectToRoute('my_profile');
         }