Merge pull request #6 from composer-version-manager/refactor-list-tags

Updated the list function to run through all pages

Author: morgan-wowk

.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+    "python.linting.pylintEnabled": true,
+    "python.linting.enabled": true
+}

cvm/services/composer_service.py

@@ -16,21 +16,14 @@ class ComposerService:
 
     def __init__(self, github_service: GitHubService):
         self.github_service = github_service
-        self.tags = None
 
     def list_tags(self):
-        if self.tags is None:
-            self.tags = self.github_service.list_tags()
-
-        return self.tags
+        return self.github_service.list_tags()
 
     def tag_exists(self, desired_tag: str) -> bool:
-        github_tags = self.list_tags()
-
-        for tag_object in github_tags:
+        for tag_object in self.list_tags():
             if tag_object.get('name') == desired_tag:
                 return True
-
         return False
 
     @staticmethod

cvm/services/github_service.py

@@ -1,5 +1,6 @@
 import logging
 import sys
+from typing import Generator
 
 import requests
 
@@ -9,17 +10,24 @@ def __init__(self, owner_id: str, repo_id: str):
         self.owner_id = owner_id
         self.repo_id = repo_id
 
-    def list_tags(self) -> requests.Response:
+    def list_tags(self) -> Generator[object]:
+
+        page = 1
         headers = {'Accept': 'application/vnd.github.v3+json'}
-        r = requests.get(
-            "https://api.github.com/repos/{}/{}/tags".format(self.owner_id, self.repo_id),
-            headers=headers
-        )
+        while True:
+
+            url = f"https://api.github.com/repos/{self.owner_id}/{self.repo_id}/tags?page={page}"
+            r = requests.get(url, headers=headers)
+
+            if not r.ok:
+                logging.error('Failed to fetch available tags from GitHub.')
+                sys.exit(1)
 
-        if r.status_code >= 400:
-            logging.error('Failed to fetch available tags from GitHub.')
-            sys.exit(1)
+            json = r.json()
+            if not json:
+                return
 
-        json = r.json()
+            for i in json:
+                yield i
+            page += 1
 
-        return json