check memory region permission on breakpoint/watchpoint creation (#166)

## Purpose
When a `Z` packet it sent to set a breakpoint or watchpoint, check the
access mask for the containing memory region and fail if it doesn't make
sense for the requested breakpoint/watchpoint type.

## Overview
* For hardware and software breakpoints, fail if the containing memory
region is not executable
* For read watchpoints, fail if the containing memory region is not
readable
* For write watchpoints, fail if the containing memory region is not
writeable
* For access watchpoints, fail if the containing memory region is not
either readable or writable.
* Enable the
`TestBadAddressBreakpoints.BadAddressBreakpointTestCase.test_bad_address_breakpoints`
lldb test case that was failing because of the missing checks

## Validation
GitHub build & test job

Author: andrurogerz

Sources/GDBRemote/DebugSessionImpl.cpp

@@ -1093,30 +1093,48 @@ ErrorCode DebugSessionImplBase::onInsertBreakpoint(
     StringCollection const &commands, bool persistentCommands) {
   DS2ASSERT(conditions.empty() && commands.empty() && !persistentCommands);
 
+  MemoryRegionInfo info;
+  CHK(_process->getMemoryRegionInfo(address, info));
+
   BreakpointManager *bpm = nullptr;
   BreakpointManager::Mode mode;
   switch (type) {
   case kSoftwareBreakpoint:
+    if (!(info.protection & kProtectionExecute))
+      return kErrorInvalidAddress;
+
     bpm = _process->softwareBreakpointManager();
     mode = BreakpointManager::kModeExec;
     break;
 
   case kHardwareBreakpoint:
+    if (!(info.protection & kProtectionExecute))
+      return kErrorInvalidAddress;
+
     bpm = _process->hardwareBreakpointManager();
     mode = BreakpointManager::kModeExec;
     break;
 
   case kReadWatchpoint:
+    if (!(info.protection & kProtectionRead))
+      return kErrorInvalidAddress;
+
     bpm = _process->hardwareBreakpointManager();
     mode = BreakpointManager::kModeRead;
     break;
 
   case kWriteWatchpoint:
+    if (!(info.protection & kProtectionWrite))
+      return kErrorInvalidAddress;
+
     bpm = _process->hardwareBreakpointManager();
     mode = BreakpointManager::kModeWrite;
     break;
 
   case kAccessWatchpoint:
+    if (!(info.protection & (kProtectionRead | kProtectionWrite)))
+      return kErrorInvalidAddress;
+
     bpm = _process->hardwareBreakpointManager();
     mode = static_cast<BreakpointManager::Mode>(BreakpointManager::kModeRead |
                                                 BreakpointManager::kModeWrite);

Support/Testing/Excluded/ds2/android-x86_64.excluded

@@ -1,5 +1,4 @@
 skip
-TestBadAddressBreakpoints.BadAddressBreakpointTestCase.test_bad_address_breakpoints
 TestBreakpointSerialization.BreakpointSerialization.test_scripted_extra_args
 TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwarf
 TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwo

Support/Testing/Excluded/ds2/linux-x86_64.excluded

@@ -1,7 +1,6 @@
 skip
 lldbsuite.test.lldbtest.TestPrintf.test_dwarf
 lldbsuite.test.lldbtest.TestPrintf.test_dwo
-TestBadAddressBreakpoints.BadAddressBreakpointTestCase.test_bad_address_breakpoints
 TestBreakpointInGlobalConstructor.TestBreakpointInGlobalConstructors.test
 TestBreakpointSerialization.BreakpointSerialization.test_scripted_extra_args
 TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwo