Remove name param from LookupConstructors

This parameter required the unscoped type name, but CppInterOp provides
no way of getting that. After speaking with Vassil on Discord, he
suggested this additional check may not actually be needed.

Author: jeaye

include/clang/Interpreter/CppInterOp.h

@@ -418,15 +418,12 @@ namespace Cpp {
 
   /// Sets a list of all the constructor for a scope/class that is
   /// supplied as a parameter.
-  ///\param[in] name - This string is used as a constraint, that clients can use
-  ///           to ensure the constructors match the name that they provide
   ///\param[in] parent - Pointer to the scope/class for which the constructors
   ///           are being looked up
   ///           to be retrieved
   ///\param[out] funcs - vector of handles to all constructors found under the
   ///            given scope
-  CPPINTEROP_API void LookupConstructors(const std::string& name,
-                                         TCppScope_t parent,
+  CPPINTEROP_API void LookupConstructors(TCppScope_t parent,
                                          std::vector<TCppFunction_t>& funcs);
 
   /// Sets a list of all the Templated Methods that are in the Class that is

lib/Interpreter/CppInterOp.cpp

@@ -1043,19 +1043,15 @@ namespace Cpp {
   }
 
   // Looks up all constructors in the current DeclContext
-  void LookupConstructors(const std::string& name, TCppScope_t parent,
+  void LookupConstructors(TCppScope_t parent,
                           std::vector<TCppFunction_t>& funcs) {
     auto* D = (Decl*)parent;
 
     if (auto* CXXRD = llvm::dyn_cast_or_null<CXXRecordDecl>(D)) {
       getSema().ForceDeclarationOfImplicitMembers(CXXRD);
       DeclContextLookupResult Result = getSema().LookupConstructors(CXXRD);
-      // Obtaining all constructors when we intend to lookup a method under a
-      // scope can lead to crashes. We avoid that by accumulating constructors
-      // only if the Decl matches the lookup name.
       for (auto* i : Result)
-        if (GetName(i) == name)
-          funcs.push_back(i);
+        funcs.push_back(i);
     }
   }