Commit 771cfa5
authored
Rollup merge of rust-lang#104543 - JhonnyBillM:migrate-codegen-ssa-to-diagnostics-structs-pt3, r=davidtwco
Migrate `codegen_ssa` to diagnostics structs - [Part 3]
Completes migrating `codegen_ssa` module except 2 outstanding errors that depend on other crates:
1. [`rustc_middle::mir::interpret::InterpError`](https://github.com/rust-lang/rust/blob/b6097f2e1b2ca62e188ba53cf43bd66b06b36915/compiler/rustc_middle/src/mir/interpret/error.rs#L475): I saw `rustc_middle` is unassigned, I am open to take this work.
2. `codegen_llvm`'s use of `fn span_invalid_monomorphization_error`, which I started to replace in the [last commit](rust-lang@9a31b3c) of this PR, but would like to know the team's preference on how we should keep replacing the other macros:
2.1. Update macros to expect a `Diagnostic`
2.2. Remove macros and expand the code on each use.
See [some examples of the different options in this experimental commit](JhonnyBillM@64aee83)
_Part 2 - https://github.com/rust-lang/rust/pull/103792_
r? ``@davidtwco``
Cc ``@compiler-errors``File tree
15 files changed
+920
-341
lines changed- compiler
- rustc_codegen_llvm/src
- rustc_codegen_ssa
- src
- back
- debuginfo
- mir
- rustc_error_messages/locales/en-US
- rustc_errors
- src
15 files changed
+920
-341
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3890 | 3890 | | |
3891 | 3891 | | |
3892 | 3892 | | |
| 3893 | + | |
3893 | 3894 | | |
3894 | 3895 | | |
3895 | 3896 | | |
| |||
4024 | 4025 | | |
4025 | 4026 | | |
4026 | 4027 | | |
| 4028 | + | |
4027 | 4029 | | |
4028 | 4030 | | |
4029 | 4031 | | |
| |||
0 commit comments