Rollup merge of rust-lang#131280 - ismailarilik:handle-potential-query-instability-lint-for-rustc-interface, r=cjgillot

matthiaskrgr · web-flow · commit 2e80beb36cbc · 2024-10-05T19:07:54.000+02:00
Handle `rustc_interface` cases of `rustc::potential_query_instability` lint This PR removes `#![allow(rustc::potential_query_instability)]` occurrences from [`compiler/rustc_interface/`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_interface/) <s>and converts `FxHash{Map,Set}` types into `FxIndex{Map,Set}` to suppress lint errors</s> (was not necessary for this PR). A somewhat tracking issue: rust-lang#84447 r? `@compiler-errors`
diff --git a/compiler/rustc_interface/src/passes.rs b/compiler/rustc_interface/src/passes.rs
@@ -470,7 +470,6 @@ fn write_out_deps(tcx: TyCtxt<'_>, outputs: &OutputFilenames, out_filenames: &[P
             })
         }
 
-        #[allow(rustc::potential_query_instability)]
         let extra_tracked_files = hash_iter_files(
             file_depinfo.iter().map(|path_sym| normalize_path(PathBuf::from(path_sym.as_str()))),
             checksum_hash_algo,

Original file line number	Diff line number	Diff line change
`@@ -470,7 +470,6 @@ fn write_out_deps(tcx: TyCtxt<'_>, outputs: &OutputFilenames, out_filenames: &[P`
`470`	`470`	`})`
`471`	`471`	`}`
`472`	`472`
`473`		`- #[allow(rustc::potential_query_instability)]`
`474`	`473`	`let extra_tracked_files = hash_iter_files(`
`475`	`474`	`file_depinfo.iter().map(\|path_sym\| normalize_path(PathBuf::from(path_sym.as_str()))),`
`476`	`475`	`checksum_hash_algo,`