Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 10, 2024

Description

as title

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

CI should just pass

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (120d514) to head (774c5ec).
Report is 482 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
+ Coverage   97.33%   97.58%   +0.24%     
==========================================
  Files          42       55      +13     
  Lines        2104     2605     +501     
==========================================
+ Hits         2048     2542     +494     
- Misses         56       63       +7     
Flag Coverage Δ
unittests 97.58% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W merged commit f41a88e into master Nov 10, 2024
21 checks passed
@Lee-W Lee-W deleted the directly-use-3.13 branch November 10, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants