test(bump_rule): raise error

Author: bearomorphism

commitizen/bump_rule.py

@@ -96,9 +96,9 @@ def __init__(
         bump_map: dict[str, Increment],
         bump_map_major_version_zero: dict[str, Increment],
     ):
-        if not bump_map or not bump_pattern:
+        if not bump_map or not bump_pattern or not bump_map_major_version_zero:
             raise NoPatternMapError(
-                f"Invalid bump rule: {bump_pattern=} and {bump_map=}"
+                f"Invalid bump rule: {bump_pattern=} and {bump_map=} and {bump_map_major_version_zero=}"
             )
 
         self.bump_pattern = re.compile(bump_pattern)

tests/test_bump_rule.py

@@ -244,6 +244,26 @@ def test_invalid_bump_map(self, bump_pattern):
         with pytest.raises(NoPatternMapError):
             OldSchoolBumpRule(bump_pattern, {}, {})
 
+    def test_invalid_bump_map_major_version_zero(self, bump_pattern, bump_map):
+        with pytest.raises(NoPatternMapError):
+            OldSchoolBumpRule(bump_pattern, bump_map, {})
+
+    def test_all_invalid(self):
+        with pytest.raises(NoPatternMapError):
+            OldSchoolBumpRule("", {}, {})
+
+    def test_none_values(self):
+        with pytest.raises(NoPatternMapError):
+            OldSchoolBumpRule(None, {}, {})
+
+    def test_empty_pattern_with_valid_maps(self, bump_map, bump_map_major_version_zero):
+        with pytest.raises(NoPatternMapError):
+            OldSchoolBumpRule("", bump_map, bump_map_major_version_zero)
+
+    def test_empty_maps_with_valid_pattern(self, bump_pattern):
+        with pytest.raises(NoPatternMapError):
+            OldSchoolBumpRule(bump_pattern, {}, {})
+
     def test_complex_pattern(self):
         pattern = r"^.*?\[(.*?)\].*?\[(.*?)\].*$"
         bump_map = {