fix(ExitCode): add from_str in ExitCode and replace parse_no_raise with it

Warn if a given decimal string is not in range

Author: bearomorphism

commitizen/cli.py

@@ -580,20 +580,19 @@ def parse_no_raise(comma_separated_no_raise: str) -> list[int]:
     Receives digits and strings and outputs the parsed integer which
     represents the exit code found in exceptions.
     """
-    no_raise_items: list[str] = comma_separated_no_raise.split(",")
-    no_raise_codes: list[int] = []
-    for item in no_raise_items:
-        if item.isdecimal():
-            no_raise_codes.append(int(item))
-            continue
+
+    def exit_code_from_str_or_skip(s: str) -> ExitCode | None:
         try:
-            exit_code = ExitCode[item.strip()]
-        except KeyError:
-            out.warn(f"WARN: no_raise key `{item}` does not exist. Skipping.")
-            continue
-        else:
-            no_raise_codes.append(exit_code.value)
-    return no_raise_codes
+            return ExitCode.from_str(s)
+        except (KeyError, ValueError):
+            out.warn(f"WARN: no_raise value `{s}` is not a valid exit code. Skipping.")
+            return None
+
+    return [
+        code.value
+        for s in comma_separated_no_raise.split(",")
+        if (code := exit_code_from_str_or_skip(s)) is not None
+    ]
 
 
 if TYPE_CHECKING:

commitizen/exceptions.py

@@ -1,10 +1,12 @@
-import enum
+from __future__ import annotations
+
+from enum import IntEnum
 from typing import Any
 
 from commitizen import out
 
 
-class ExitCode(enum.IntEnum):
+class ExitCode(IntEnum):
     EXPECTED_EXIT = 0
     NO_COMMITIZEN_FOUND = 1
     NOT_A_GIT_PROJECT = 2
@@ -39,6 +41,12 @@ class ExitCode(enum.IntEnum):
     CONFIG_FILE_IS_EMPTY = 31
     COMMIT_MESSAGE_LENGTH_LIMIT_EXCEEDED = 32
 
+    @classmethod
+    def from_str(cls, value: str) -> ExitCode:
+        if value.isdecimal():
+            return cls(int(value))
+        return cls[value.strip()]
+
 
 class CommitizenException(Exception):
     def __init__(self, *args: str, **kwargs: Any) -> None:

tests/test_exceptions.py

@@ -0,0 +1,38 @@
+import pytest
+
+from commitizen.exceptions import ExitCode
+
+
+def test_from_str_with_decimal():
+    """Test from_str with decimal values."""
+    assert ExitCode.from_str("0") == ExitCode.EXPECTED_EXIT
+    assert ExitCode.from_str("1") == ExitCode.NO_COMMITIZEN_FOUND
+    assert ExitCode.from_str("32") == ExitCode.COMMIT_MESSAGE_LENGTH_LIMIT_EXCEEDED
+
+
+def test_from_str_with_enum_name():
+    """Test from_str with enum names."""
+    assert ExitCode.from_str("EXPECTED_EXIT") == ExitCode.EXPECTED_EXIT
+    assert ExitCode.from_str("NO_COMMITIZEN_FOUND") == ExitCode.NO_COMMITIZEN_FOUND
+    assert (
+        ExitCode.from_str("COMMIT_MESSAGE_LENGTH_LIMIT_EXCEEDED")
+        == ExitCode.COMMIT_MESSAGE_LENGTH_LIMIT_EXCEEDED
+    )
+
+
+def test_from_str_with_whitespace():
+    """Test from_str with whitespace in enum names."""
+    assert ExitCode.from_str("  EXPECTED_EXIT  ") == ExitCode.EXPECTED_EXIT
+    assert ExitCode.from_str("\tNO_COMMITIZEN_FOUND\t") == ExitCode.NO_COMMITIZEN_FOUND
+
+
+def test_from_str_with_invalid_values():
+    """Test from_str with invalid values."""
+    with pytest.raises(KeyError):
+        ExitCode.from_str("invalid_name")
+    with pytest.raises(ValueError):
+        ExitCode.from_str("999")  # Out of range decimal
+    with pytest.raises(KeyError):
+        ExitCode.from_str("")
+    with pytest.raises(KeyError):
+        ExitCode.from_str(" ")