refactor(bump_rule): rename and fix test

Author: bearomorphism

commitizen/bump_rule.py

@@ -96,9 +96,9 @@ def get_increment(
 
         Returns:
             SemVerIncrement | None: The type of version increment needed:
-                - "MAJOR": For breaking changes when major_version_zero is False
-                - "MINOR": For breaking changes when major_version_zero is True, or for new features
-                - "PATCH": For bug fixes, performance improvements, or refactors
+                - MAJOR: For breaking changes when major_version_zero is False
+                - MINOR: For breaking changes when major_version_zero is True, or for new features
+                - PATCH: For bug fixes, performance improvements, or refactors
                 - None: For commits that don't require a version bump (docs, style, etc.)
         """
         ...
@@ -149,9 +149,7 @@ def _head_pattern(self) -> re.Pattern:
         return re.compile(f"^{re_change_type}{re_scope}{re_bang}:")
 
 
-class OldSchoolBumpRule(BumpRule):
-    """TODO: rename?"""
-
+class CustomBumpRule(BumpRule):
     def __init__(
         self,
         bump_pattern: str,

commitizen/commands/bump.py

@@ -8,7 +8,7 @@
 
 from commitizen import bump, factory, git, hooks, out
 from commitizen.bump_rule import (
-    OldSchoolBumpRule,
+    CustomBumpRule,
     SemVerIncrement,
     find_increment_by_callable,
 )
@@ -127,8 +127,8 @@ def find_increment(self, commits: list[git.GitCommit]) -> SemVerIncrement | None
         # Update the bump map to ensure major version doesn't increment.
         is_major_version_zero: bool = self.bump_settings["major_version_zero"]
 
-        # Fallback to old school bump rule if no bump rule is provided
-        rule = self.cz.bump_rule or OldSchoolBumpRule(
+        # Fallback to custom bump rule if no bump rule is provided
+        rule = self.cz.bump_rule or CustomBumpRule(
             *self._get_validated_cz_bump(),
         )