refactor(Bump): remove use of getattr

bearomorphism · Lee-W · commit c953f6180fc0 · 2025-11-08T15:34:57.000+08:00
diff --git a/commitizen/commands/bump.py b/commitizen/commands/bump.py
@@ -216,8 +216,8 @@ def __call__(self) -> None:
 
         rules = TagRules.from_settings(cast(Settings, self.bump_settings))
         current_tag = rules.find_tag_for(git.get_tags(), current_version)
-        current_tag_version = getattr(
-            current_tag, "name", rules.normalize_tag(current_version)
+        current_tag_version = (
+            current_tag.name if current_tag else rules.normalize_tag(current_version)
         )
 
         is_initial = self._is_initial_tag(current_tag, self.arguments["yes"])

Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,8 @@ def __call__(self) -> None:`
`216`	`216`
`217`	`217`	`rules = TagRules.from_settings(cast(Settings, self.bump_settings))`
`218`	`218`	`current_tag = rules.find_tag_for(git.get_tags(), current_version)`
`219`		`- current_tag_version = getattr(`
`220`		`- current_tag, "name", rules.normalize_tag(current_version)`
	`219`	`+ current_tag_version = (`
	`220`	`+ current_tag.name if current_tag else rules.normalize_tag(current_version)`
`221`	`221`	`)`
`222`	`222`
`223`	`223`	`is_initial = self._is_initial_tag(current_tag, self.arguments["yes"])`