refactor(commands/commit): use direct async class and open tty as binmod

Author: saygox

commitizen/commands/commit.py

@@ -7,7 +7,8 @@
 import subprocess
 import sys
 import tempfile
-from asyncio import DefaultEventLoopPolicy, get_event_loop_policy, set_event_loop_policy
+from asyncio import get_event_loop_policy, set_event_loop_policy
+from asyncio.unix_events import _UnixDefaultEventLoopPolicy
 from io import IOBase
 
 import questionary
@@ -30,7 +31,7 @@
 from commitizen.git import smart_open
 
 
-class CZEventLoopPolicy(DefaultEventLoopPolicy):
+class CZEventLoopPolicy(_UnixDefaultEventLoopPolicy):
     def get_event_loop(self):
         self.set_event_loop(self._loop_factory(selectors.SelectSelector()))
         return self._local._loop
@@ -44,7 +45,7 @@ def __init__(self, stdx: IOBase):
                 fd = os.open("/dev/tty", os.O_RDWR | os.O_NOCTTY)
                 tty = open(fd, "wb+", buffering=0)
             else:
-                tty = open("/dev/tty", "w")
+                tty = open("/dev/tty", "wb")
         else:
             fd = os.open("/dev/tty", os.O_RDWR | os.O_NOCTTY)
             if self._fileno == 0:

tests/commands/test_commit_command.py

@@ -575,7 +575,7 @@ def test_WrapStdx(mocker):
     wrap_stout.write("data")
 
     if sys.platform == "linux":
-        writer_mock.assert_called_once_with("/dev/tty", "w")
+        writer_mock.assert_called_once_with("/dev/tty", "wb")
     else:
         pass
     writer_mock().write.assert_called_once_with("data")
@@ -589,7 +589,7 @@ def test_WrapStdx(mocker):
     wrap_sterr.write("data")
 
     if sys.platform == "linux":
-        writer_mock.assert_called_once_with("/dev/tty", "w")
+        writer_mock.assert_called_once_with("/dev/tty", "wb")
     else:
         pass
     writer_mock().write.assert_called_once_with("data")