Skip to content

Commit 3d501c1

Browse files
bearomorphismLee-W
authored andcommitted
refactor: remove unnecessary class member tag_format
1 parent 5e9c5f5 commit 3d501c1

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

commitizen/changelog_formats/base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ def __init__(self, config: BaseConfig) -> None:
2525
# See: https://bugs.python.org/issue44807
2626
self.config = config
2727
self.encoding = self.config.settings["encoding"]
28-
self.tag_format = self.config.settings["tag_format"]
2928
self.tag_rules = TagRules(
3029
scheme=get_version_scheme(self.config.settings),
31-
tag_format=self.tag_format,
30+
tag_format=self.config.settings["tag_format"],
3231
legacy_tag_formats=self.config.settings["legacy_tag_formats"],
3332
ignored_tag_formats=self.config.settings["ignored_tag_formats"],
3433
)

commitizen/commands/changelog.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,10 @@ def __init__(self, config: BaseConfig, arguments: ChangelogArgs) -> None:
104104
or defaults.CHANGE_TYPE_ORDER,
105105
)
106106
self.rev_range = arguments.get("rev_range")
107-
self.tag_format = (
108-
arguments.get("tag_format") or self.config.settings["tag_format"]
109-
)
110107
self.tag_rules = TagRules(
111108
scheme=self.scheme,
112-
tag_format=self.tag_format,
109+
tag_format=arguments.get("tag_format")
110+
or self.config.settings["tag_format"],
113111
legacy_tag_formats=self.config.settings["legacy_tag_formats"],
114112
ignored_tag_formats=self.config.settings["ignored_tag_formats"],
115113
merge_prereleases=arguments.get("merge_prerelease")

0 commit comments

Comments
 (0)