test: Some cleanup and fix if CWD not project root

Author: robertschweizer

tests/test_changelog.py

@@ -1,3 +1,5 @@
+from pathlib import Path
+
 import pytest
 
 from commitizen import changelog, defaults, git
@@ -495,7 +497,7 @@ def tags() -> list:
 
 @pytest.fixture
 def changelog_content() -> str:
-    changelog_path = "tests/CHANGELOG_FOR_TEST.md"
+    changelog_path = Path(__file__).parent / "CHANGELOG_FOR_TEST.md"
     with open(changelog_path, "r") as f:
         return f.read()
 

tests/test_conf.py

@@ -1,5 +1,4 @@
 import json
-import os
 from pathlib import Path
 
 import pytest
@@ -41,7 +40,7 @@
 }
 
 
-_settings = {
+_read_settings = {
     "name": "cz_jira",
     "version": "1.0.0",
     "version_provider": "commitizen",
@@ -85,16 +84,6 @@
     "version_type": None,
 }
 
-_read_settings = {
-    "name": "cz_jira",
-    "version": "1.0.0",
-    "version_files": ["commitizen/__version__.py", "pyproject.toml"],
-    "style": [["pointer", "reverse"], ["question", "underline"]],
-    "changelog_file": "CHANGELOG.md",
-    "pre_bump_hooks": ["scripts/generate_documentation.sh"],
-    "post_bump_hooks": ["scripts/slack_notification.sh"],
-}
-
 
 @pytest.fixture
 def config_files_manager(request, tmpdir):
@@ -111,7 +100,7 @@ def config_files_manager(request, tmpdir):
 
 
 def test_find_git_project_root(tmpdir):
-    assert git.find_git_project_root() == Path(os.getcwd())
+    assert git.find_git_project_root() == Path(__file__).parent.parent
 
     with tmpdir.as_cwd() as _:
         assert git.find_git_project_root() is None
@@ -133,7 +122,7 @@ class TestReadCfg:
     )
     def test_load_conf(_, config_files_manager):
         cfg = config.read_cfg()
-        assert cfg.settings == _settings
+        assert cfg.settings == _read_settings
 
     def test_conf_returns_default_when_no_files(_, tmpdir):
         with tmpdir.as_cwd():
@@ -148,7 +137,7 @@ def test_load_empty_pyproject_toml_and_cz_toml_with_config(_, tmpdir):
             p.write(PYPROJECT)
 
             cfg = config.read_cfg()
-            assert cfg.settings == _settings
+            assert cfg.settings == _read_settings
 
 
 class TestTomlConfig: