Generic NPE error without details on product/variant import

[drazenhrgar]

Describe the bug
When we try to import a new product and one of the variants on the product has the same key the import fails but there is no detailed message as to why. The same is the case when we try to import a new product with an existing SLUG, there is always the same, generic error message. This was working before but seems like in some update of the library or on Commercetools side it just gives generic NPE.

This is an issue when we need to report to the calling system why did the import fail.

To Reproduce
Steps to reproduce the behavior:

1. Import a new product with the same Slug as an existing product
2. NPE happens without any details

Expected behavior
Error details

Screenshots

[lojzatran]

Hi @drazenhrgar,

Thank you for reporting the issue. I added a test according to your steps, but I could not reproduce it. Can you tell me if I understood the problem correctly? #1202

[drazenhrgar]

Hi @lojzatran!

this is our snipped how we build the product draft and we are executing the sync in one run with an array of product drafts

I see in your test the first product draft doesn't have a key, maybe an "updateAction" fails?

Full stack trace.

stack_trace.txt

[lojzatran]

Hi @drazenhrgar

Thank you for the code snippet.

I see in your test the first product draft doesn't have a key, maybe an "updateAction" fails?

It actually does have keys, it is just hidden inside the method call createProductDraftBuilder(). If you look at the assert part of the test, it checks if the error contains A duplicate value '\\\"slug\\\"' exists for field message: https://github.com/commercetools/commercetools-sync-java/pull/1202/files#diff-a071429222431ab13644136b81b6e6b16ff9f559bc571142f336d9a46764a270R1009-R1012

From what I could see in your code you don't have any variants. While this is possible, it is not a common use case. Can you explain why you don't have any variants in the product?

[drazenhrgar]

Hi @lojzatran !

I am referring back to this. Think the issue is that we used .withStaticTokenFlow() when creating the API client.

We noticed that when you create an API client withStaticTokenFlow included and not with clientCredentials that it doesn't throw exceptions/errors on the API so we would say this is the root cause of it in this library.

This is a general issue with the Java SDK would say. Can you confirm?