Skip to content

Commit 926a0b4

Browse files
committed
Add react-helmet for title
1 parent 2be4ad9 commit 926a0b4

File tree

4 files changed

+33
-4
lines changed

4 files changed

+33
-4
lines changed

common/layouts/server.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!doctype html>
22
<html>
33
<head>
4-
<title><%= title %></title>
4+
<%= helmet.title %>
55
<meta charset="utf-8" />
66
<meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width height=device-height" />
77
<link rel="shortcut icon" type="image/x-icon" href="<%= favicon %>">

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@
145145
"postcss-loader": "^2.0.6",
146146
"react": "^15.5.4",
147147
"react-dom": "^15.5.4",
148+
"react-helmet": "^5.1.3",
148149
"react-hot-loader": "next",
149150
"react-redux": "^5.0.4",
150151
"react-router-dom": "^4.1.1",

server/render.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// cache the main layout template with lodash
22
import { template } from 'lodash';
33
import { renderToString } from 'react-dom/server';
4-
import config from './config';
4+
import { Helmet } from 'react-helmet';
55

66
const { NODE_ENV } = process.env;
77
const compile = template(require('../common/layouts/server.html'));
@@ -13,15 +13,15 @@ export default function render(component, initialState = {}) {
1313
}
1414

1515
const assets = global.ISOTools.assets();
16-
const title = config.name;
1716
const favicon = assets.assets['./common/images/favicon.png'];
1817
const vendorJs = assets.javascript.vendor;
1918
const appJs = assets.javascript.app;
2019
const html = renderToString(component);
20+
const helmet = Helmet.renderStatic();
2121
const vendorCss = assets.styles.vendor;
2222
const appCss = assets.styles.app;
2323

2424
return compile(
25-
{ html, title, favicon, vendorCss, appCss, vendorJs, appJs, initialState }
25+
{ html, helmet, favicon, vendorCss, appCss, vendorJs, appJs, initialState }
2626
);
2727
}

yarn.lock

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,6 +1607,10 @@ deep-diff@0.3.4:
16071607
version "0.3.4"
16081608
resolved "https://registry.yarnpkg.com/deep-diff/-/deep-diff-0.3.4.tgz#aac5c39952236abe5f037a2349060ba01b00ae48"
16091609

1610+
deep-equal@^1.0.1:
1611+
version "1.0.1"
1612+
resolved "https://registry.yarnpkg.com/deep-equal/-/deep-equal-1.0.1.tgz#f5d260292b660e084eff4cdbc9f08ad3247448b5"
1613+
16101614
deep-extend@~0.4.0:
16111615
version "0.4.1"
16121616
resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.4.1.tgz#efe4113d08085f4e6f9687759810f807469e2253"
@@ -2020,6 +2024,10 @@ evp_bytestokey@^1.0.0:
20202024
dependencies:
20212025
create-hash "^1.1.1"
20222026

2027+
exenv@^1.2.1:
2028+
version "1.2.2"
2029+
resolved "https://registry.yarnpkg.com/exenv/-/exenv-1.2.2.tgz#2ae78e85d9894158670b03d47bec1f03bd91bb9d"
2030+
20232031
expand-brackets@^0.1.4:
20242032
version "0.1.5"
20252033
resolved "https://registry.yarnpkg.com/expand-brackets/-/expand-brackets-0.1.5.tgz#df07284e342a807cd733ac5af72411e581d1177b"
@@ -4332,6 +4340,15 @@ react-dom@^15.5.4:
43324340
object-assign "^4.1.0"
43334341
prop-types "~15.5.7"
43344342

4343+
react-helmet@^5.1.3:
4344+
version "5.1.3"
4345+
resolved "https://registry.yarnpkg.com/react-helmet/-/react-helmet-5.1.3.tgz#cd40626593a29eecf684b6d38d711f44c48188af"
4346+
dependencies:
4347+
deep-equal "^1.0.1"
4348+
object-assign "^4.1.1"
4349+
prop-types "^15.5.4"
4350+
react-side-effect "^1.1.0"
4351+
43354352
react-hot-loader@next:
43364353
version "3.0.0-beta.6"
43374354
resolved "https://registry.yarnpkg.com/react-hot-loader/-/react-hot-loader-3.0.0-beta.6.tgz#463fac0bfc8b63a8385258af20c91636abce75f4"
@@ -4390,6 +4407,13 @@ react-router@^4.1.1:
43904407
prop-types "^15.5.4"
43914408
warning "^3.0.0"
43924409

4410+
react-side-effect@^1.1.0:
4411+
version "1.1.3"
4412+
resolved "https://registry.yarnpkg.com/react-side-effect/-/react-side-effect-1.1.3.tgz#512c25abe0dec172834c4001ec5c51e04d41bc5c"
4413+
dependencies:
4414+
exenv "^1.2.1"
4415+
shallowequal "^1.0.1"
4416+
43934417
react-transform-catch-errors@^1.0.2:
43944418
version "1.0.2"
43954419
resolved "https://registry.yarnpkg.com/react-transform-catch-errors/-/react-transform-catch-errors-1.0.2.tgz#1b4d4a76e97271896fc16fe3086c793ec88a9eeb"
@@ -4873,6 +4897,10 @@ shallow-clone@^0.1.2:
48734897
lazy-cache "^0.2.3"
48744898
mixin-object "^2.0.1"
48754899

4900+
shallowequal@^1.0.1:
4901+
version "1.0.2"
4902+
resolved "https://registry.yarnpkg.com/shallowequal/-/shallowequal-1.0.2.tgz#1561dbdefb8c01408100319085764da3fcf83f8f"
4903+
48764904
signal-exit@^3.0.0:
48774905
version "3.0.1"
48784906
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.1.tgz#5a4c884992b63a7acd9badb7894c3ee9cfccad81"

0 commit comments

Comments
 (0)