Skip to content

Commit 6170e9e

Browse files
committed
fix: CI failures - remove Swift 6.0 jobs and add missing await
- Remove Swift 6.0 from Linux CI matrix (package requires 6.1+) - Remove Xcode 16.2 from macOS CI matrix (uses Swift 6.0.3) - Add missing await to withKnownIssue in InsertTests.swift:392 Fixes CI failures where Swift 6.0 couldn't build the package.
1 parent 16970cc commit 6170e9e

File tree

3 files changed

+48
-6
lines changed

3 files changed

+48
-6
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ jobs:
2121
fail-fast: false
2222
matrix:
2323
include:
24-
- os: '15'
25-
xcode: '16.2'
26-
swift: '6.1'
2724
- os: '26'
2825
xcode: '26.0'
2926
swift: '6.2'
@@ -64,7 +61,6 @@ jobs:
6461
fail-fast: false
6562
matrix:
6663
swift:
67-
- '6.0'
6864
- '6.1'
6965
- '6.2'
7066
steps:

Architecture.md

Lines changed: 47 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1422,7 +1422,7 @@ Conducted comprehensive audit against [PostgreSQL SELECT Documentation](https://
14221422
// Define named window once
14231423
Employee
14241424
.window("dept_salary") {
1425-
WindowSpec()
1425+
$0
14261426
.partition(by: $0.department)
14271427
.order(by: $0.salary.desc())
14281428
}
@@ -1729,3 +1729,49 @@ func distinct(
17291729
**For historical context on how we arrived at these architectural decisions, see HISTORY.md**
17301730
**For testing patterns and best practices, see TESTING.md**
17311731
**For PostgreSQL Chapter 9 coverage, see "PostgreSQL Coverage" section above**
1732+
1733+
1734+
1735+
I realize the AI output wasn't too helpful last time. Sorry about that..
1736+
was doing my best but squeezed for time.
1737+
1738+
Wanted to let you know about the next SQ-postgres release, and some firsthand experience that might be more useful!
1739+
1740+
Release URL: v0.1.0 of swift-structured-queries-postgres:
1741+
https://github.com/coenttb/swift-structured-queries-postgres/releases/ta
1742+
g/0.1.0
1743+
1744+
I've added quite a few PostgreSQL-specific features, all following SQ's API
1745+
patterns, such as FTS, Triggers, Window functions, JSONB operations, Postgres Array, and advanced aggregates.
1746+
1747+
FTS and Triggers sections were particularly tricky to get right. My compliments to you both for figuring those out from scatch.
1748+
1749+
585 tests pass almost instantly, including parallel execution. I added
1750+
postgres-nio behind a trait to upgrade assertSQL to both print generated
1751+
SQL AND validate syntax against PostgreSQL. swift-records has the full
1752+
assertQuery (printing + database execution) for integration tests.
1753+
1754+
Technical challanges I faced:
1755+
1756+
Swift-syntax linker errors: Solved by pinning to
1757+
swift-6.2-DEVELOPMENT-SNAPSHOT-2025-10-09-a. If you have insights on a
1758+
more robust approach, I'd love to hear them.
1759+
1760+
Replacing `any`: I noticed you mentioned some cases crash the compiler
1761+
requiring `any`. I experimented and replaced most `any` uses with `some` without issues
1762+
- though I'm on Xcode+toolchain 26.1 with latest swift-syntax snapshot, which
1763+
might explain the difference. Happy to share specifics if you're
1764+
curious.
1765+
1766+
Upstream sync
1767+
1768+
The packages have diverged significantly, so it's not currently trivial to sync via pull and merge. Workable to do it manually (AI helps), but if you have better ideas I'd love to hear.
1769+
1770+
I haven't had the chance to experiment with enum tables and nested
1771+
Selections in a real-world project yet, but I'll let you know my
1772+
findings once I get to that.
1773+
1774+
Working on SQ and SQ-postgres is a joy because no other project I work on has such
1775+
advanced mechanics, especially parameter packs. I learn something new every day.
1776+
1777+
Thanks for building such a solid foundation!

Tests/StructuredQueriesPostgresTests/Commands/Insert/InsertTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ extension SnapshotTests {
389389
// NB: This currently crashes in Xcode 26.
390390
#if swift(<6.2)
391391
@Test func onConflict_invalidUpdateFilters() async {
392-
withKnownIssue {
392+
await withKnownIssue {
393393
await assertSQL(
394394
of: Reminder.insert {
395395
Reminder.Draft(remindersListID: 1)

0 commit comments

Comments
 (0)