Fix #29 -- Do not filter based on empty search term

Author: codingjoe

django_select2/forms.py

@@ -400,13 +400,14 @@ def filter_queryset(self, request, term, queryset=None, **dependent_fields):
         search_fields = self.get_search_fields()
         select = Q()
 
-        for field in search_fields:
-            field_select = Q(**{field: term})
-            if "contains" in field:
-                for word in filter(None, self._word_split_pattern.split(term)):
-                    field_select |= Q(**{field: word})
-
-            select |= field_select
+        if term != "":
+            for field in search_fields:
+                field_select = Q(**{field: term})
+                if "contains" in field:
+                    for word in filter(None, self._word_split_pattern.split(term)):
+                        field_select |= Q(**{field: word})
+
+                select |= field_select
 
         if dependent_fields:
             select &= Q(**dependent_fields)

tests/test_forms.py

@@ -446,6 +446,16 @@ def test_filter_queryset(self, genres):
         )
         assert qs.exists()
 
+    def test_filter_queryset__empty(self, genres):
+        widget = TitleModelSelect2Widget(queryset=Genre.objects.all())
+        assert widget.filter_queryset(None, genres[0].title[:3]).exists()
+
+        widget = TitleModelSelect2Widget(
+            search_fields=["title__icontains"], queryset=Genre.objects.all()
+        )
+        qs = widget.filter_queryset(None, "")
+        assert qs.exists()
+
     def test_filter_queryset__startswith(self, genres):
         genre = Genre.objects.create(title="Space Genre")
         widget = TitleModelSelect2Widget(queryset=Genre.objects.all())