Skip to content

Commit c374450

Browse files
authored
Fix identical operator by casting parameters in RequestBodyRange (#33)
1 parent 7cb50d4 commit c374450

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/Range/RequestBodyRange.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ public function __construct($request, string $indexKey, string $numberOfChunksKe
3030
$request = $request->request;
3131
}
3232

33-
$this->index = $request->get($indexKey);
34-
$this->numberOfChunks = $request->get($numberOfChunksKey);
35-
$this->chunkSize = $request->get($chunkSizeKey);
36-
$this->totalSize = $request->get($totalSizeKey);
33+
$this->index = (int) $request->get($indexKey);
34+
$this->numberOfChunks = (int) $request->get($numberOfChunksKey);
35+
$this->chunkSize = (int) $request->get($chunkSizeKey);
36+
// Must be double (which is an alias for float) for 32 bit systems
37+
$this->totalSize = (double) $request->get($totalSizeKey);
3738

3839
if ($this->numberOfChunks <= 0) {
3940
throw new InvalidArgumentException(sprintf('`%s` must be greater than zero', $numberOfChunksKey));

tests/Range/RequestBodyRangeTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,10 @@ public function testCreateFromRequest()
135135
private function createRequestBodyRange($index, $numberOfChunks, $chunkSize, $totalSize)
136136
{
137137
$request = new ParameterBag([
138-
'index' => $index,
139-
'numberOfChunks' => $numberOfChunks,
140-
'chunkSize' => $chunkSize,
141-
'totalSize' => $totalSize,
138+
'index' => (string) $index,
139+
'numberOfChunks' => (string) $numberOfChunks,
140+
'chunkSize' => (string) $chunkSize,
141+
'totalSize' => (string) $totalSize,
142142
]);
143143

144144
return new RequestBodyRange($request, 'index', 'numberOfChunks', 'chunkSize', 'totalSize');

0 commit comments

Comments
 (0)