feat(unit-tests): add tests for SubmitValidator

Author: prabalsingh24

test/e2e/SubmitScenario.spec.ts

@@ -24,13 +24,13 @@ const source = `
 const testcases = [
     {
         id: 1,
-        stdin: 'https://minio.cb.lk/public/input',
-        stdout: 'https://minio.cb.lk/public/input'
+        input: 'https://minio.cb.lk/public/input',
+        output: 'https://minio.cb.lk/public/input'
     },
     {
         id: 2,
-        stdin: 'https://minio.cb.lk/public/input',
-        stdout: 'https://minio.cb.lk/public/input'
+        input: 'https://minio.cb.lk/public/input',
+        output: 'https://minio.cb.lk/public/input'
     }
 ];
 const expectedResult = 'Success';
@@ -215,4 +215,22 @@ describe('POST api/submissions', () => {
         expect(res.status).to.equal(200);
         expect(resultFromCallBack.result).to.equal(expectedResult);
     });
+
+    it('should throw 400 error for incorrect testcases ', async () => {
+        const params = {
+            source: (new Buffer(source).toString('base64')),
+            lang: 'cpp',
+            mode: 'poll',
+            timelimit: 1,
+            testcases: []
+        };
+
+        const res = await chai.request(app).post(`/api/submissions`).set({
+            Authorization: 'Bearer 7718330d2794406c980bdbded6c9dc1d',
+            Accept: 'application/json'
+        }).send(params);
+
+        expect(res.status).to.equal(400);
+        expect(res.body.err.message).to.equal('"testcases" must contain at least 1 items');
+    });
 });

test/unit/validators/RunValidator.spec.ts

@@ -137,6 +137,23 @@ describe('RunValidator', async () => {
         expect(sentData.err.message).to.equal('"mode" must be one of [sync, callback, poll]');
     });
 
+    it('should throw error if mode is callback and callback is missing', async () => {
+        const req = {
+            body: {
+                source: 'LKJSDFKLMC414CcnBcba12',
+                lang: 'cpp',
+                mode: 'callback',
+                stdin: ''
+            }
+        };
+
+        await runValidator.POST(req, res, nextSpy);
+
+        expect(sentStatus).to.be.equal(400);
+        expect(sentData.err.message).to.equal('"callback" is required');
+        expect(nextSpy.calledOnce).to.be.false;
+    });
+
     it('should not throw an error with STDIN missing', async () => {
         const req = {
             body: {
@@ -200,24 +217,7 @@ describe('RunValidator', async () => {
         expect(nextSpy.calledOnce).to.be.false;
     });
 
-    it('should throw error if mode is callback and callback is missing', async () => {
-        const req = {
-            body: {
-                source: 'LKJSDFKLMC414CcnBcba12',
-                lang: 'cpp',
-                mode: 'callback',
-                stdin: ''
-            }
-        };
-
-        await runValidator.POST(req, res, nextSpy);
-
-        expect(sentStatus).to.be.equal(400);
-        expect(sentData.err.message).to.equal('"callback" is required');
-        expect(nextSpy.calledOnce).to.be.false;
-    });
-
-    it('shoud NOT throw error for correct values', async () => {
+    it('should NOT throw error for correct values', async () => {
         const req = {
             body: {
                 source: 'LKJSDFKLMC414CcnBcba12',