fix: language validation in submit and run

Author: jatinkatyal13

src/middlewares/langValidator.ts

@@ -0,0 +1,18 @@
+import DB from 'models';
+import { Request, Response, NextFunction } from 'express';
+
+export default (key = 'body') => async (req: Request, res: Response, next: NextFunction) => {
+  const lang_slug = req[key].lang
+  const lang = await DB.langs.findOne({
+    where: {
+      lang_slug
+    }
+  })
+  if (!lang) {
+    return res.status(400).json({
+      message: 'Language not Found'
+    })
+  }
+
+  return next()
+}

src/routes/api/run/index.ts

@@ -2,11 +2,12 @@ import { Router } from 'express'
 import Controller from './controller'
 import Validator from './validators'
 import { successListener } from 'rabbitmq/jobqueue'
+import langValidator from 'middlewares/langValidator';
 
 const router: Router = Router()
 const validator = new Validator()
 
-router.post('/', validator.POST, Controller.runPOST)
+router.post('/', validator.POST, langValidator(), Controller.runPOST)
 successListener.on('run_result', Controller.onSuccess)
 
 export default router

src/routes/api/submit/index.ts

@@ -2,11 +2,12 @@ import { Router } from 'express'
 import Controller from './controller'
 import Validator from './validators'
 import { successListener } from 'rabbitmq/jobqueue'
+import langValidator from 'middlewares/langValidator'
 
 const router: Router = Router()
 const validator = new Validator()
 
-router.post('/', validator.POST, Controller.submitPOST)
+router.post('/', validator.POST, langValidator(), Controller.submitPOST)
 successListener.on('submit_result', Controller.onSuccess)
 
 export default router

test/unit/validators/RunValidator.spec.ts

@@ -41,21 +41,6 @@ describe('RunValidator', async () => {
         expect(nextSpy.calledOnce).to.be.false;
     });
 
-    it('should throw an error with incorrect language', async () => {
-        const req = {
-            body: {
-                source: 'LKJSDFKLMC414CcnBcba12',
-                lang: 'wrongLang',
-                mode: 'sync',
-                stdin: 'INPUT'
-            }
-        };
-
-        await runValidator.POST(req, res, nextSpy);
-        expect(sentStatus).to.equal(400);
-        expect(nextSpy.calledOnce).to.be.false;
-    });
-
     it('should throw an error when source is missing', async () => {
         const req = {
             body: {

test/unit/validators/SubmitValidator.spec.ts

@@ -53,22 +53,6 @@ describe('SubmitValidator', async () => {
         expect(nextSpy.calledOnce).to.be.false;
     });
 
-    it('should throw an error with incorrect language', async () => {
-        const req = {
-            body: {
-                source: 'LKJSDFKLMC414CcnBcba12',
-                lang: 'wrongLang',
-                mode: 'sync',
-                testcases
-            }
-        };
-
-        await submitValidator.POST(req, res, nextSpy);
-
-        expect(sentStatus).to.equal(400);
-        expect(nextSpy.calledOnce).to.be.false;
-    });
-
     it('should throw an error when source is missing', async () => {
         const req = {
             body: {