Skip to content

Commit 51afa93

Browse files
committed
Small tests refactor
1 parent fe39936 commit 51afa93

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

tests/UniqueTranslationTest.php

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ public function it_checks_if_the_translation_for_the_current_locale_is_unique()
2222
'name' => UniqueTranslationRule::for($this->table),
2323
];
2424

25+
// The following validation fails, because the
26+
// current locale is "en", so we actually set
27+
// ['en' => 'existing-slug-en'] etc.
28+
2529
$validation = Validator::make([
2630
'slug' => 'existing-slug-en',
2731
'name' => 'existing-name-en',
@@ -30,14 +34,15 @@ public function it_checks_if_the_translation_for_the_current_locale_is_unique()
3034
$this->assertTrue($validation->fails());
3135
$this->assertEquals(['slug', 'slug.en', 'name', 'name.en'], $validation->errors()->keys());
3236

37+
// The following validation passes, because the
38+
// current locale is "en", so we actually set
39+
// ['en' => 'existing-slug-nl'] etc.
40+
3341
$validation = Validator::make([
3442
'slug' => 'existing-slug-nl',
3543
'name' => 'existing-name-nl',
3644
], $rules);
3745

38-
// This passes because the current locale is "en", so we
39-
// actually set ['en' => 'existing-slug-nl'] etc.
40-
4146
$this->assertTrue($validation->passes());
4247
$this->assertEmpty($validation->errors()->keys());
4348
}
@@ -63,14 +68,6 @@ public function it_checks_if_the_translation_for_a_specific_locale_is_unique()
6368
$this->assertTrue($validation->fails());
6469
$this->assertEquals(['slug', 'slug.en', 'name', 'name.en'], $validation->errors()->keys());
6570

66-
$validation = Validator::make([
67-
'slug' => ['nl' => 'existing-slug-nl'],
68-
'name' => ['nl' => 'existing-name-nl'],
69-
], $rules);
70-
71-
$this->assertTrue($validation->fails());
72-
$this->assertEquals(['slug', 'slug.nl', 'name', 'name.nl'], $validation->errors()->keys());
73-
7471
$validation = Validator::make([
7572
'slug' => ['en' => 'different-slug-en'],
7673
'name' => ['en' => 'different-name-en'],
@@ -79,6 +76,14 @@ public function it_checks_if_the_translation_for_a_specific_locale_is_unique()
7976
$this->assertTrue($validation->passes());
8077
$this->assertEmpty($validation->errors()->keys());
8178

79+
$validation = Validator::make([
80+
'slug' => ['nl' => 'existing-slug-nl'],
81+
'name' => ['nl' => 'existing-name-nl'],
82+
], $rules);
83+
84+
$this->assertTrue($validation->fails());
85+
$this->assertEquals(['slug', 'slug.nl', 'name', 'name.nl'], $validation->errors()->keys());
86+
8287
$validation = Validator::make([
8388
'slug' => ['nl' => 'different-slug-en'],
8489
'name' => ['nl' => 'different-name-en'],

0 commit comments

Comments
 (0)