Support spatie/nova-translatable (#7)

Author: ivanvermeyen

src/UniqueTranslationValidator.php

@@ -21,7 +21,9 @@ class UniqueTranslationValidator
      */
     public function validate($attribute, $value, $parameters, $validator)
     {
-        list ($name, $locale) = $this->getAttributeNameAndLocale($attribute);
+        list ($name, $locale) = $this->isNovaTranslation($attribute)
+            ? $this->getNovaAttributeNameAndLocale($attribute)
+            : $this->getArrayAttributeNameAndLocale($attribute);
 
         if ($this->isUnique($value, $name, $locale, $parameters)) {
             return true;
@@ -49,6 +51,7 @@ protected function setMissingErrorMessages($validator, $name, $locale)
             "{$name}.{$rule}",
             "{$name}.*.{$rule}",
             "{$name}.{$locale}.{$rule}",
+            "translations_{$name}_{$locale}.{$rule}",
         ];
 
         foreach ($keys as $key) {
@@ -58,21 +61,87 @@ protected function setMissingErrorMessages($validator, $name, $locale)
         }
     }
 
+    /**
+     * Check if the attribute is a Nova translation field name.
+     *
+     * @param string $attribute
+     *
+     * @return bool
+     */
+    protected function isNovaTranslation($attribute)
+    {
+        return strpos($attribute, '.') === false && strpos($attribute, 'translations_') === 0;
+    }
+
+    /**
+     * Get the attribute name and locale of a Nova translation field.
+     *
+     * @param string $attribute
+     *
+     * @return array
+     */
+    protected function getNovaAttributeNameAndLocale($attribute)
+    {
+        $attribute = str_replace('translations_', '', $attribute);
+
+        return $this->getAttributeNameAndLocale($attribute, '_');
+    }
+
+    /**
+     * Get the attribute name and locale of an array field.
+     *
+     * @param string $attribute
+     *
+     * @return array
+     */
+    protected function getArrayAttributeNameAndLocale($attribute)
+    {
+        return $this->getAttributeNameAndLocale($attribute, '.');
+    }
+
     /**
      * Get the attribute name and locale.
      *
      * @param string $attribute
+     * @param string $delimiter
      *
      * @return array
      */
-    protected function getAttributeNameAndLocale($attribute)
+    protected function getAttributeNameAndLocale($attribute, $delimiter)
+    {
+        $locale = $this->getAttributeLocale($attribute, $delimiter);
+        $name = $this->getAttributeName($attribute, $locale, $delimiter);
+
+        return [$name, $locale ?: App::getLocale()];
+    }
+
+    /**
+     * Get the locale from the attribute name.
+     *
+     * @param string $attribute
+     * @param string $delimiter
+     *
+     * @return string|null
+     */
+    protected function getAttributeLocale($attribute, $delimiter)
     {
-        $parts = explode('.', $attribute);
+        $pos = strrpos($attribute, $delimiter);
 
-        $name = $parts[0];
-        $locale = $parts[1] ?? App::getLocale();
+        return $pos > 0 ? substr($attribute, $pos +  1) : null;
+    }
 
-        return [$name, $locale];
+    /**
+     * Get the attribute name without the locale.
+     *
+     * @param string $attribute
+     * @param string|null $locale
+     * @param string $delimiter
+     *
+     * @return string
+     */
+    protected function getAttributeName($attribute, $locale, $delimiter)
+    {
+        return $locale ? str_replace("{$delimiter}{$locale}", '', $attribute) : $attribute;
     }
 
     /**

tests/UniqueTranslationTest.php

@@ -237,4 +237,32 @@ public function it_ignores_null_values()
 
         $this->assertTrue($validation->passes());
     }
+
+    /** @test */
+    public function it_validates_nova_translations()
+    {
+        Model::create([
+            'slug' => ['nl' => 'existing-slug-nl'],
+            'name' => ['nl' => 'existing-name-nl'],
+        ]);
+
+        $rules = [
+            'translations_slug_nl' => "{$this->rule}:{$this->table},slug",
+            'translations_name_nl' => UniqueTranslationRule::for($this->table, 'slug'),
+        ];
+
+        $validation = Validator::make([
+            'translations_slug_nl' => 'existing-slug-nl',
+            'translations_name_nl' => 'existing-name-nl',
+        ], $rules);
+
+        $this->assertTrue($validation->fails());
+
+        $validation = Validator::make([
+            'translations_slug_nl' => 'different-slug-nl',
+            'translations_name_nl' => 'different-name-nl',
+        ], $rules);
+
+        $this->assertTrue($validation->passes());
+    }
 }

tests/ValidationMessageTest.php

@@ -139,4 +139,36 @@ public function it_returns_a_custom_error_message_when_validating_an_array()
             'form_name.en' => [$expectedNameError],
         ], $validation->errors()->messages());
     }
+
+    /** @test */
+    public function it_returns_a_default_error_message_when_validating_a_nova_translation()
+    {
+        Model::create([
+            'slug' => ['en' => 'existing-slug-en'],
+            'name' => ['en' => 'existing-name-en'],
+        ]);
+
+        $formAttributes = [
+            'translations_form_slug_en' => ['en' => 'existing-slug-en'],
+            'translations_form_name_en' => ['en' => 'existing-name-en'],
+        ];
+
+        $rules = [
+            'translations_form_slug_en' => "{$this->rule}:{$this->table},slug",
+            'translations_form_name_en' => UniqueTranslationRule::for($this->table, 'name'),
+        ];
+
+        $expectedSlugError = trans('validation.unique', ['attribute' => 'translations form slug en']);
+        $expectedNameError = trans('validation.unique', ['attribute' => 'translations form name en']);
+
+        $this->assertNotEmpty($expectedSlugError);
+        $this->assertNotEmpty($expectedNameError);
+
+        $validation = Validator::make($formAttributes, $rules);
+
+        $this->assertEquals([
+            'translations_form_slug_en' => [$expectedSlugError],
+            'translations_form_name_en' => [$expectedNameError],
+        ], $validation->errors()->messages());
+    }
 }