Add test for empty locale values

Author: ivanvermeyen

tests/Unit/LocalizerTest.php

@@ -16,8 +16,6 @@ public function it_loops_through_the_detectors_and_returns_the_first_supported_l
     {
         $supportedLocales = ['en', 'nl'];
         $detectors = [
-            Mockery::mock(Detector::class)->allows()->detect()->andReturns(false)->getMock(),
-            Mockery::mock(Detector::class)->allows()->detect()->andReturns(null)->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('de')->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('nl')->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('en')->getMock(),
@@ -46,8 +44,6 @@ public function it_returns_false_if_no_supported_locale_could_be_detected()
     {
         $supportedLocales = ['en'];
         $detectors = [
-            Mockery::mock(Detector::class)->allows()->detect()->andReturns(false)->getMock(),
-            Mockery::mock(Detector::class)->allows()->detect()->andReturns(null)->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('de')->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('nl')->getMock(),
             Mockery::mock(Detector::class)->allows()->detect()->andReturns('fr')->getMock(),
@@ -58,6 +54,23 @@ public function it_returns_false_if_no_supported_locale_could_be_detected()
         $this->assertFalse($localizer->detect());
     }
 
+    /** @test */
+    public function it_skips_null_and_false_and_empty_values()
+    {
+        $supportedLocales = ['nl'];
+        $detectors = [
+            Mockery::mock(Detector::class)->allows()->detect()->andReturns(false)->getMock(),
+            Mockery::mock(Detector::class)->allows()->detect()->andReturns(null)->getMock(),
+            Mockery::mock(Detector::class)->allows()->detect()->andReturns([])->getMock(),
+            Mockery::mock(Detector::class)->allows()->detect()->andReturns('')->getMock(),
+            Mockery::mock(Detector::class)->allows()->detect()->andReturns('nl')->getMock(),
+        ];
+
+        $localizer = new Localizer($supportedLocales, $detectors);
+
+        $this->assertEquals('nl', $localizer->detect());
+    }
+
     /** @test */
     public function it_loops_through_the_stores_and_calls_the_store_method_with_the_given_locale()
     {