chore: remove unused browser tests and selenium-webdriver dependency #8821
Conversation
- Remove browsers.test.js which was added for IE11 testing - IE11, iOS, and Android tests were already skipped - Firefox and Safari tests required selenium-webdriver which is not installed - Fixes CI failure: Cannot find module 'selenium-webdriver'
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
* chore: add puppeteer dependency for integration tests * fix: ensure snapshot identifiers include -snap suffix * test: update integration test snapshots * test: increase snapshot thresholds to account for OS rendering differences * chore: bump CircleCI cache version to v39 to invalidate stale caches * fix: use correct jest-image-snapshot API for percentage thresholds * chore: comment customDiffConfig and add logging to be sure it runs correctly * fix: update thresholds to account for OS rendering diffs * fix: snapshot threshold override * fix: update snapshot threshold
![arnica-github-connector[bot]](https://avatars.githubusercontent.com/in/144692?s=60&v=4){kind=small}
| resolved "https://registry.yarnpkg.com/extract-files/-/extract-files-9.0.0.tgz#8a7744f2437f81f5ed3250ed9f1550de902fe54a" | ||
| integrity sha512-CvdFfHkC95B4bBBk36hcEmvdR2awOdhhVUYH6S/zrVj3477zven/fJMYg7121h4T1xHZC+tetUpubpAhxwI7hQ== | ||
|
|
||
| extract-zip@2.0.1: |
There was a problem hiding this comment.
Dependency Risk: ip@2.0.1 has 1 vulnerability
Severity: High 🚨
Status: Open 🔴
Suggested reviewers 🧐: @tristandubbeld
More details:
If you see an issue, please contact either @shasheen in the #security-engineering slack channel
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk:
[arnica] ack <acknowledge additional details>
To dismiss the risk with a reason:
[arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and im looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
| integrity sha512-4WK/bYZmj8xLr+HUCODHGF1ZFzsYffasLUgEiMBY4fgtltdO6B4WJtlSbPaDTLpYTcGVwM2qLnFTICEcNxs3kA== | ||
|
|
||
| tar-stream@^2.2.0, tar-stream@~2.2.0: | ||
| tar-fs@2.1.1: |
There was a problem hiding this comment.
Dependency Risk: tar-fs@2.1.1 has 3 vulnerabilities
Upgrade to version 2.1.4 to mitigate all risks. This is a patch change from the installed version.
Severity: High 🚨
Status: Open 🔴
Suggested reviewers 🧐: @tristandubbeld
More details:
If you see an issue, please contact either @shasheen in the #security-engineering slack channel
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk:
[arnica] ack <acknowledge additional details>
To dismiss the risk with a reason:
[arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and im looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
| resolved "https://registry.yarnpkg.com/ws/-/ws-8.13.0.tgz#9a9fb92f93cf41512a0735c8f4dd09b8a1211cd0" | ||
| integrity sha512-x9vcZYTrFPC7aSIbj7sRCYo7L/Xb8Iy+pW0ng0wt2vCJv7M9HOMy0UoN3rr+IFC7hb7vXoqS+P9ktyLLLhO+LA== | ||
|
|
||
| ws@8.9.0: |
There was a problem hiding this comment.
Dependency Risk: ws@8.9.0 has 1 vulnerability
Upgrade to version 8.17.1 to mitigate all risks. This is a minor change from the installed version.
Severity: High 🚨
Status: Open 🔴
Suggested reviewers 🧐: @tristandubbeld
More details:
If you see an issue, please contact either @shasheen in the #security-engineering slack channel
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk:
[arnica] ack <acknowledge additional details>
To dismiss the risk with a reason:
[arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and im looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
tristandubbeld
deleted the
tristan/csb-678-get-rid-of-selenium-webdriver-dependency
branch
Problem
CI integration tests are failing with:
Cannot find module 'selenium-webdriver'error in browsers.test.jsSolution
browsers.test.jswhich contained BrowserStack tests requiring selenium-webdriverImpact
This PR also contains changes from #8822 to fix snapshot testing.