Corrected so that the StackTrace is included when new incidents are saved.

Reporting errors to our own instance of codeRR is now mandatory.

Author: codeRR

src/Server/Coderr.Server.ReportAnalyzer/Inbound/SaveReportHandler.cs

@@ -30,14 +30,13 @@ public class SaveReportHandler
         /// <summary>
         ///     Creates a new instance of <see cref="SaveReportHandler" />.
         /// </summary>
-        /// <param name="queueProvider">provider</param>
+        /// <param name="queue">Queue used to enqueue new error reports</param>
         /// <param name="connectionFactory">Tries to find connection named "Queue" and uses default if not found.</param>
         /// <exception cref="ArgumentNullException">queueProvider;connectionFactory</exception>
-        public SaveReportHandler(IMessageQueueProvider queueProvider, IConnectionFactory connectionFactory)
+        public SaveReportHandler(IMessageQueue queue, IConnectionFactory connectionFactory)
         {
-            if (queueProvider == null) throw new ArgumentNullException(nameof(queueProvider));
+            _queue = queue ?? throw new ArgumentNullException(nameof(queue));
             _connectionFactory = connectionFactory ?? throw new ArgumentNullException(nameof(connectionFactory));
-            _queue = queueProvider.Open("ReportQueue");
         }
 
         public void AddFilter(Func<NewReportDTO, bool> filter)
@@ -71,7 +70,7 @@ public async Task BuildReportAsync(string appKey, string signatureProvidedByTheC
 
             var report = DeserializeBody(reportBody);
 
-            //fix malconfigured clients
+            // correct incorrect clients
             if (report.CreatedAtUtc > DateTime.UtcNow)
                 report.CreatedAtUtc = DateTime.UtcNow;
 

src/Server/Coderr.Server.ReportAnalyzer/Services/ReportAnalyzer.cs

@@ -75,9 +75,9 @@ public void Analyze(ErrorReportEntity report)
             }
             else
             {
-                if (incident.ReportCount > 10000)
+                if (incident.ReportCount > 1000)
                 {
-                    _logger.Debug("Reportcount is more than 10000. Ignoring report for incident " + incident.Id);
+                    _logger.Debug("Report count is more than 10000. Ignoring report for incident " + incident.Id);
                     return;
                 }
 

src/Server/Coderr.Server.SqlServer/Analysis/AnalyticsRepository.cs

@@ -71,10 +71,10 @@ FROM Incidents
 
         public void CreateIncident(IncidentBeingAnalyzed incident)
         {
+            if (incident == null) throw new ArgumentNullException("incident");
             if (string.IsNullOrEmpty(incident.ReportHashCode))
                 throw new InvalidOperationException("ReportHashCode is required to be able to detect duplicates");
 
-            if (incident == null) throw new ArgumentNullException("incident");
             using (var cmd = _unitOfWork.CreateCommand())
             {
                 cmd.CommandText =
@@ -88,6 +88,7 @@ public void CreateIncident(IncidentBeingAnalyzed incident)
                 cmd.AddParameter("ReportCount", incident.ReportCount);
                 cmd.AddParameter("UpdatedAtUtc", incident.UpdatedAtUtc);
                 cmd.AddParameter("Description", incident.Description);
+                cmd.AddParameter("StackTrace", incident.StackTrace);
                 cmd.AddParameter("FullName", incident.FullName);
                 var id = (int) (decimal) cmd.ExecuteScalar();
                 incident.GetType()

src/Server/Coderr.Server.SqlServer/Analysis/Incident2Mapper.cs renamed to src/Server/Coderr.Server.SqlServer/Analysis/IncidentBeingAnalyzedMapper.cs

@@ -4,9 +4,9 @@
 
 namespace codeRR.Server.SqlServer.Analysis
 {
-    public class Incident2Mapper : CrudEntityMapper<IncidentBeingAnalyzed>
+    public class IncidentBeingAnalyzedMapper : CrudEntityMapper<IncidentBeingAnalyzed>
     {
-        public Incident2Mapper()
+        public IncidentBeingAnalyzedMapper()
             : base("Incidents")
         {
             Property(x => x.UpdatedAtUtc)

src/Server/Coderr.Server.Web/App_Start/RouteConfig.cs

@@ -10,7 +10,7 @@ public static void RegisterInstallationRoutes(RouteCollection routes)
             routes.MapRoute(
                 "Default",
                 "{controller}/{action}/{id}",
-                new {controller = "Home", action = "ToInstall", id = UrlParameter.Optional},
+                new {controller = "Boot", action = "ToInstall", id = UrlParameter.Optional},
                 new[] {"codeRR.Server.Web.Controllers"}
                 );
         }

src/Server/Coderr.Server.Web/Areas/Installation/Controllers/BootController.cs

@@ -0,0 +1,35 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Web;
+using System.Web.Mvc;
+
+namespace codeRR.Server.Web.Areas.Installation.Controllers
+{
+    /// <summary>
+    /// Purpose is to be able to launch installation area and be able to use dependencies in the home controller
+    /// </summary>
+    public class BootController : Controller
+    {
+        public ActionResult Index()
+        {
+            return RedirectToAction("Index", "Home");
+        }
+
+        [AllowAnonymous, Route("installation/{*url}")]
+        public ActionResult NoInstallation()
+        {
+            if (Request.Url.AbsolutePath.EndsWith("/setup/activate", StringComparison.OrdinalIgnoreCase))
+                return Redirect("~/?#/welcome");
+            return View();
+        }
+
+        [AllowAnonymous]
+        public ActionResult ToInstall()
+        {
+            return RedirectToRoute(new { Controller = "Setup", Area = "Installation" });
+        }
+
+
+    }
+}

src/Server/Coderr.Server.Web/Areas/Installation/Controllers/SetupController.cs

@@ -81,9 +81,7 @@ public ActionResult Errors()
             var config = ConfigurationStore.Instance.Load<codeRRConfigSection>();
             if (config != null)
             {
-                model.ActivateTracking = config.ActivateTracking;
                 model.ContactEmail = config.ContactEmail;
-                model.InstallationId = config.InstallationId;
             }
             else
             {
@@ -101,9 +99,9 @@ public ActionResult Errors(ErrorTrackingViewModel model)
 
             var settings = new codeRRConfigSection
             {
-                ActivateTracking = model.ActivateTracking,
+                ActivateTracking = true,
                 ContactEmail = model.ContactEmail,
-                InstallationId = model.InstallationId
+                InstallationId = Guid.NewGuid().ToString("N")
             };
             ConfigurationStore.Instance.Store(settings);
             return Redirect(Url.GetNextWizardStep());

src/Server/Coderr.Server.Web/Areas/Installation/Models/ErrorTrackingViewModel.cs

@@ -4,20 +4,8 @@ namespace codeRR.Server.Web.Areas.Installation.Models
 {
     public class ErrorTrackingViewModel
     {
-        [Display(Name = "Activate tracking")]
-        public bool ActivateTracking { get; set; }
-
         [Display(Name = "Contact email"), EmailAddress]
         public string ContactEmail { get; set; }
 
-        /// <summary>
-        ///     A fixed identity which identifies this specific installation. You can generate a GUID and then store it.
-        /// </summary>
-        /// <remarks>
-        ///     <para>
-        ///         Used to identify the number of installations that have the same issue.
-        ///     </para>
-        /// </remarks>
-        public string InstallationId { get; set; }
     }
 }

src/Server/Coderr.Server.Web/Areas/Installation/Views/Setup/ErrorTracking.cshtml

@@ -7,28 +7,22 @@
 
         <h2>Error tracking</h2>
         <p>
-            To correct bugs much faster we would like to activate codeRR for your installation. All exceptions
-            will be uploaded to our own installation for further analysis.
+            To correct bugs faster we have activated codeRR in the community server. By completing this
+            setup, you allow us to collect error information and sent it to our own hosted service.
+        </p>
+        <p>
+            You can optionally enter your email address to get notifications when the errors in your
+            installation have been corrected and released. 
+        </p>
+        <p>
+            <em>(We might also contact you if we need more information
+                about the error)</em>
         </p>
         <form method="post" action="@Url.Action("Errors")" style="width: 100%" class="form">
             @Html.ValidationSummary(false)
-            <div class="form-group">
-                @Html.CheckBoxFor(x => x.ActivateTracking, new {@class = "form-control", style = "display:inline;height:auto;width:inherit;"})
-                @Html.LabelFor(x => x.ActivateTracking, new {@class = "control-label"})
-                <br/>
-                <small>Allow us to track errors.</small>
-            </div>
             <div class="form-group disabled suboption">
                 @Html.LabelFor(x => x.ContactEmail, new {@class = "control-label"})
-                @Html.TextBoxFor(x => x.ContactEmail, new {@class = "form-control", disabled = ""})
-                <small>Email address that we may contact if we need any further information (will also receive notifications when your errors have been corrected).</small>
-            </div>
-            <div class="form-group disabled suboption">
-                @Html.LabelFor(x => x.InstallationId, new {@class = "control-label"})
-                @Html.TextBoxFor(x => x.InstallationId, new {@class = "form-control", disabled = ""})
-                <small>A fixed identity which identifies this specific installation. You can generate a GUID and then store it. Used to identify the number of installations that have the same issue.</small>
-                <br/>
-                <small>A guid generated for your convencience if you want to enable this feature: @Guid.NewGuid().ToString("N")</small>
+                @Html.TextBoxFor(x => x.ContactEmail, new {@class = "form-control", placeholder = "Your email address"})
             </div>
             <br/>
             @Html.Raw(ViewBag.PrevLink)

src/Server/Coderr.Server.Web/Areas/Receiver/Controllers/FeedbackController.cs

@@ -20,7 +20,7 @@ public class FeedbackController : ApiController
     {
         private readonly ILog _logger = LogManager.GetLogger(typeof(FeedbackController));
         private readonly IMessageQueue _queue;
-        private IConnectionFactory _connectionFactory;
+        private readonly IConnectionFactory _connectionFactory;
 
         public FeedbackController(IMessageQueueProvider queueProvider, IConnectionFactory connectionFactory)
         {