v2.1

Author: jgauffin

src/Server/Coderr.Server.SqlServer/Coderr.Server.SqlServer.csproj

@@ -26,7 +26,4 @@
     <EmbeddedResource Include="Schema\*.sql" />
   </ItemGroup>
 
-  <ItemGroup>
-    <None Remove="Schema\Coderr.v19.sql" />
-  </ItemGroup>
 </Project>

src/Server/Coderr.Server.SqlServer/Core/Applications/Queries/GetApplicationOverviewHandler.cs

@@ -57,13 +57,13 @@ public async Task<GetApplicationOverviewResult> HandleAsync(IMessageContext cont
                     filter1 = "WHERE ";
                     filter2 = "WHERE ";
                 }
-                var sql = @"select cast(Incidents.CreatedAtUtc as date), count(Id)
+                var sql = @"select cast(Incidents.CreatedAtUtc as date), count(Incidents.Id)
 from Incidents
 {2} Incidents.CreatedAtUtc >= @minDate
 AND Incidents.CreatedAtUtc <= GetUtcDate()
 {0}
 group by cast(Incidents.CreatedAtUtc as date);
-select cast(IncidentReports.CreatedAtUtc as date), count(Id)
+select cast(IncidentReports.ReceivedAtUtc as date), count(IncidentReports.Id)
 from IncidentReports
 join Incidents isa ON (isa.Id = IncidentReports.IncidentId)
 {3} IncidentReports.ReceivedAtUtc >= @minDate
@@ -135,7 +135,8 @@ JOIN IncidentVersions ON (IncidentReports.IncidentId = IncidentVersions.Incident
 AND ReceivedAtUtc <= GetUtcDate()
 AND ApplicationId = @appId;
 
-SELECT count(distinct emailaddress) from IncidentFeedback
+SELECT count(distinct emailaddress) 
+from IncidentFeedback
 JOIN IncidentVersions ON (IncidentFeedback.IncidentId = IncidentVersions.IncidentId)
 WHERE IncidentVersions.VersionId = @versionId
 AND CreatedAtUtc >= @minDate
@@ -144,7 +145,8 @@ JOIN IncidentVersions ON (IncidentFeedback.IncidentId = IncidentVersions.Inciden
 AND emailaddress is not null
 AND DATALENGTH(emailaddress) > 0;
 
-select count(*) from IncidentFeedback 
+select count(*) 
+from IncidentFeedback 
 JOIN IncidentVersions ON (IncidentFeedback.IncidentId = IncidentVersions.IncidentId)
 WHERE IncidentVersions.VersionId = @versionId
 AND CreatedAtUtc >= @minDate
@@ -163,21 +165,23 @@ AND Description is not null
 AND Incidents.State <> {(int)IncidentState.Ignored}
 AND Incidents.State <> {(int)IncidentState.Closed};
 
-SELECT count(id) 
+SELECT count(IncidentReports.id) 
 FROM IncidentReports
 JOIN Incidents ON (Incidents.Id = IncidentReports.IncidentId)
 WHERE ReceivedAtUtc >= @minDate
 AND ReceivedAtUtc <= GetUtcDate()
 AND ApplicationId = @appId;
 
-select count(distinct emailaddress) from IncidentFeedback
+select count(distinct emailaddress) 
+from IncidentFeedback
 where CreatedAtUtc >= @minDate
 AND CreatedAtUtc <= GetUtcDate()
 AND ApplicationId = @appId
 AND emailaddress is not null
 AND DATALENGTH(emailaddress) > 0;
 
-select count(*) from IncidentFeedback 
+select count(*) 
+from IncidentFeedback 
 where CreatedAtUtc >= @minDate
 AND CreatedAtUtc <= GetUtcDate()
 AND ApplicationId = @appId

src/Server/Coderr.Server.SqlServer/ReportAnalyzer/Feedback/LookupReportsForFeedback.cs

@@ -88,16 +88,16 @@ private async Task LookupReportInfo(IEnumerable<UserFeedback> items)
                 {
                     if (item.ErrorId != null)
                     {
-                        cmd.CommandText = @"SELECT Id, ApplicationId, IncidentId 
-                                                FROM IncidentReports  WITH(NOLOCK) 
-                                                JOIN Incidents ON (Incidents.Id = IncidentId) WITH(NOLOCK) 
+                        cmd.CommandText = @"SELECT IncidentReports.Id, ApplicationId, IncidentId 
+                                                FROM IncidentReports 
+                                                JOIN Incidents WITH(READUNCOMMITTED)  ON (Incidents.Id = IncidentId)
                                                 WHERE ErrorId = @id";
                         cmd.AddParameter("id", item.ErrorId);
                     }
                     else
                     {
                         cmd.CommandText = @"SELECT Id, ApplicationId, IncidentId 
-                                            FROM ErrorReports WITH(NOLOCK) 
+                                            FROM ErrorReports 
                                             WHERE Id = @id";
                         cmd.AddParameter("id", item.ReportId);
                     }

src/Server/Coderr.Server.Web/appsettings.json

@@ -5,7 +5,7 @@
   } ,
   "EnableCors":  true, 
   "ConnectionStrings": {
-    "Db": "Data Source=.;Initial Catalog=Coderr99;Integrated Security=True;Connect Timeout=15;"
+    "Db": "Data Source=.;Initial Catalog=CoderrDep;Integrated Security=True;Connect Timeout=15;"
   },
   "Logging": {
     "IncludeScopes": false,