Corrected error (regression tests)

Author: jgauffin

src/Server/Coderr.Server.ReportAnalyzer/Incidents/IncidentBeingAnalyzed.cs

@@ -93,7 +93,7 @@ public string Description
         }
 
         /// <summary>
-        /// List of all environment names that the developer specified when reporting the errors.
+        ///     List of all environment names that the developer specified when reporting the errors.
         /// </summary>
         public string[] EnvironmentNames { get; set; }
 
@@ -139,13 +139,19 @@ public string Description
         public bool IsReOpened { get; set; }
 
         /// <summary>
-        /// When we received a report (just to keep track of how fresh this incident is).
+        ///     When we received a report (just to keep track of how fresh this incident is).
         /// </summary>
         public DateTime LastReportAtUtc { get; set; }
 
         /// <summary>
-        /// When we received a report that we stored.
+        ///     When we received a report that we actual stored.
         /// </summary>
+        /// <remarks>
+        ///     <para>
+        ///         This field is used to determine if we should store another report today, while <see cref="LastReportAtUtc" />
+        ///         is just used to keep track of when we received the most recent report.
+        ///     </para>
+        /// </remarks>
         public DateTime LastStoredReportUtc { get; set; }
 
         /// <summary>
@@ -204,10 +210,7 @@ public void AddReport(ErrorReportEntity entity)
                 StackTrace = entity.Exception.StackTrace;
             }
 
-            if (LastReportAtUtc < entity.CreatedAtUtc)
-                LastReportAtUtc = entity.CreatedAtUtc;
-
-
+            LastReportAtUtc = entity.CreatedAtUtc;
             ReportCount++;
         }
 

src/Server/Coderr.Server.ReportAnalyzer/UserNotifications/Handlers/CheckForNotificationsToSend.cs

@@ -56,9 +56,9 @@ public async Task HandleAsync(IMessageContext context, ReportAddedToIncident e)
             {
                 if (setting.NewIncident != NotificationState.Disabled && e.IsNewIncident == true)
                 {
-                    if (e.EnvironmentName.Equals("production", StringComparison.OrdinalIgnoreCase) ||
-                        e.EnvironmentName.Equals("prod", StringComparison.OrdinalIgnoreCase)
-                        || string.IsNullOrEmpty(e.EnvironmentName))
+                    if (string.IsNullOrEmpty(e.EnvironmentName)
+                    || e.EnvironmentName.Equals("production", StringComparison.OrdinalIgnoreCase)
+                        || e.EnvironmentName.Equals("prod", StringComparison.OrdinalIgnoreCase))
                     {
                         await CreateNotification(context, e, setting.AccountId, setting.NewIncident);
                     }

src/Server/Coderr.Server.ReportAnalyzer/UserNotifications/NotificationService.cs renamed to src/Server/Coderr.Server.SqlServer/Core/Notifications/NotificationService.cs

@@ -7,6 +7,7 @@
 
 namespace Coderr.Server.ReportAnalyzer.UserNotifications
 {
+    // Must be here so that it can be used from both queues.
     /// <summary>
     /// Implementation of <see cref="INotificationService"/>.
     /// </summary>

src/Server/Coderr.Server.SqlServer/Modules/Versions/Queries/GetApplicationVersionsHandler.cs

@@ -23,8 +23,8 @@ public async Task<GetApplicationVersionsResult> HandleAsync(IMessageContext cont
         {
             var sql =
                 @"SELECT version, sum(incidentcount) incidentcount, sum(reportcount) reportcount, min(FirstReportDate) as FirstReportDate, max(LastReportDate)as LastReportDate
-  FROM ApplicationVersions
-  join ApplicationVersionMonths on (versionid=applicationversions.id)
+  FROM ApplicationVersions WITH (NoLock)
+  join ApplicationVersionMonths WITH (NoLock) on (versionid=applicationversions.id)
   where applicationid=@appId
   group by version
   order by version

src/Server/Coderr.Server.SqlServer/ReportAnalyzer/AnalyticsRepository.cs

@@ -71,11 +71,16 @@ public void CreateIncident(IncidentBeingAnalyzed incident)
             if (string.IsNullOrEmpty(incident.ReportHashCode))
                 throw new InvalidOperationException("ReportHashCode is required to be able to detect duplicates");
 
+            if (incident.LastReportAtUtc == DateTime.MinValue)
+                incident.LastReportAtUtc = DateTime.UtcNow;
+            if (incident.LastStoredReportUtc == DateTime.MinValue)
+                incident.LastStoredReportUtc = DateTime.UtcNow;
+
             using (var cmd = _unitOfWork.CreateCommand())
             {
                 cmd.CommandText =
-                    "INSERT INTO Incidents (ReportHashCode, ApplicationId, CreatedAtUtc, HashCodeIdentifier, StackTrace, ReportCount, UpdatedAtUtc, Description, FullName, IsReOpened, LastReportAtUtc)" +
-                    " VALUES (@ReportHashCode, @ApplicationId, @CreatedAtUtc, @HashCodeIdentifier, @StackTrace, @ReportCount, @UpdatedAtUtc, @Description, @FullName, 0, @LastReportAtUtc);select SCOPE_IDENTITY();";
+                    "INSERT INTO Incidents (ReportHashCode, ApplicationId, CreatedAtUtc, HashCodeIdentifier, StackTrace, ReportCount, UpdatedAtUtc, Description, FullName, IsReOpened, LastStoredReportUtc, LastReportAtUtc)" +
+                    " VALUES (@ReportHashCode, @ApplicationId, @CreatedAtUtc, @HashCodeIdentifier, @StackTrace, @ReportCount, @UpdatedAtUtc, @Description, @FullName, 0, @LastStoredReportUtc, @LastReportAtUtc);select SCOPE_IDENTITY();";
                 cmd.AddParameter("Id", incident.Id);
                 cmd.AddParameter("ReportHashCode", incident.ReportHashCode);
                 cmd.AddParameter("ApplicationId", incident.ApplicationId);
@@ -86,6 +91,7 @@ public void CreateIncident(IncidentBeingAnalyzed incident)
                 cmd.AddParameter("Description", incident.Description);
                 cmd.AddParameter("StackTrace", incident.StackTrace);
                 cmd.AddParameter("FullName", incident.FullName);
+                cmd.AddParameter("LastStoredReportUtc", incident.LastStoredReportUtc);
                 cmd.AddParameter("LastReportAtUtc", incident.LastReportAtUtc);
                 var id = (int) (decimal) cmd.ExecuteScalar();
                 incident.GetType()

src/Server/Coderr.Server.Web/ClientApp/components/discover/application/configure.vue.html

@@ -46,7 +46,7 @@ <h5>
                 </div>
             </div>
             <div class="card-footer">
-                <button class="btn btn-blue" v-on:click.prevent="completedConfiguration">Configuration is complete &gt;&gt;</button>
+                <button class="btn btn-blue" id="config-complete-button" v-on:click.prevent="completedConfiguration">Configuration is complete &gt;&gt;</button>
             </div>
         </div>
     </div>

src/Server/Coderr.Server.Web/ClientApp/components/discover/home/home.vue.html

@@ -51,7 +51,7 @@
                     <router-link class="btn btn-primary btn-sm" v-bind:click="assignBestToMe">{{myBestSuggestion.Description}}</router-link>
                 </div>
                 <div class="card">
-                    <div class="card-header">
+                    <div class="card-header" id="chart-summary-header">
                         <span v-if="applicationId == 0">Incident trend per application</span>
                         <span v-else>Incident trend</span>
                     </div>

src/Server/Coderr.Server.Web/ClientApp/components/home/navmenu/navmenu.ts

@@ -40,6 +40,7 @@ export default class NavMenuComponent extends Vue {
         this.myApplicationsPromise = new Promise((accept, reject) => {
             AppRoot.Instance.loadCurrentUser().then(x => {
                 this.allApps = x.applications;
+                this.myApplications = x.applications;
                 accept();
             });
         });

src/Server/Coderr.Server.Web/ClientApp/components/home/navmenu/navmenu.vue.html

@@ -24,7 +24,7 @@
                             <a v-on:click.prevent="changeApplication(null)" class="dropdown-item"><i class="fa fa-home"></i> All applications</a>
                             <div class="dropdown-divider"></div>
                             <div v-for="item in myApplications">
-                                <a href="#" v-on:click.prevent="changeApplication(item.tag)" class="dropdown-item text-black-50"><i class="fa-desktop fa"></i> {{item.title}}</a>
+                                <a href="#" v-on:click.prevent="changeApplication(item.id)" class="dropdown-item text-black-50"><i class="fa-desktop fa"></i> {{item.name}}</a>
                             </div>
                         </div>
                     </li>

src/Tools/Coderr.IntegrationTests/Coderr.IntegrationTests/Entities/IncidentWrapper.cs

@@ -168,7 +168,12 @@ async Task<bool> Func()
 
         public async Task UpdateByLastReceivedReport(Func<GetIncidentResult, bool> filter = null)
         {
-            await Update(x => x.LastReportReceivedAtUtc > DTO.LastReportReceivedAtUtc);
+            await Update(x =>
+            {
+                Console.WriteLine(
+                    $"Comparing our {DTO.LastReportReceivedAtUtc:yyyyMMdd hh:mm:ss.fff} with server {x.LastReportReceivedAtUtc:yyyyMMdd hh:mm:ss.fff}");
+                return x.LastReportReceivedAtUtc > DTO.LastReportReceivedAtUtc;
+            });
         }
     }
 }